sem/builtins: audit a few tests for randomized test tenant #155741
+90
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
force-pushed
the
tenant-builtins
branch
2 times, most recently
from
2030c50 to
60458ab
Compare
This commit adjusts one test to work with randomized test tenant. Additionally, it exempts 3 tests from that randomization since those are specific to PerStore RPCs that we currently don't expose for secondary tenants. It also adjusts `TestSerialNormalizationWithUniqueUnorderedID` which is quite heavy to exempt the default test tenant from rate limiting to avoid timeouts. Release note: None
yuzefovich
force-pushed
the
tenant-builtins
branch
from
60458ab to
c4ce72e
Compare
We now have this handy helper which can replace older `ALTER TENANT` plus "wait for capabilities" combo (which still happens under the hood). Release note: None
yuzefovich
force-pushed
the
tenant-builtins
branch
from
c4ce72e to
cebc29a
Compare
yuzefovich
requested review from
a team and
mgartner
and removed request for
a team
yuzefovich
requested review from
a team,
angles-n-daemons and
jeffswenson
and removed request for
a team,
angles-n-daemons and
jeffswenson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adjusts one test to work with randomized test tenant. Additionally, it exempts 3 tests from that randomization since those are specific to PerStore RPCs that we currently don't expose for secondary tenants.
It also adjusts
TestSerialNormalizationWithUniqueUnorderedIDwhich is quite heavy to exempt the default test tenant from rate limiting to avoid timeouts.Informs: #76378.
Epic: CRDB-48945
Release note: None