Skip to content

Conversation

kev-cao
Copy link
Contributor

@kev-cao kev-cao commented Oct 20, 2025

Backport 1/1 commits from #155292 on behalf of @kev-cao.


LDR currently erroneously requires the db name in the external connection with setting up a bidirectional connection. This was determined to be caused by the fact that the privilege lookup on the source cluster was using unqualified table names during the reverse stream setup. This commit fixes the issue by using fully qualified table names.

Fixes: #152395

Release note: LDR no longer requires the database name to be specified in the external connection URI when setting up a bidirectional stream.


Release justification: Trivial bug fix to unblock broken LDR jobs.

LDR currently erroneously requires the db name in the external
connection with setting up a bidirectional connection. This was
determined to be caused by the fact that the privilege lookup on the
source cluster was using unqualified table names during the reverse
stream setup. This commit fixes the issue by using fully qualified table
names.

Fixes: cockroachdb#152395

Release note: LDR no longer requires the database name to be specified
in the external connection URI when setting up a bidirectional stream.
@kev-cao kev-cao requested a review from a team as a code owner October 20, 2025 21:16
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 20, 2025
@kev-cao kev-cao requested review from jeffswenson and removed request for a team October 20, 2025 21:16
@blathers-crl
Copy link

blathers-crl bot commented Oct 20, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-disaster-recovery labels Oct 20, 2025
@blathers-crl
Copy link

blathers-crl bot commented Oct 20, 2025

✅ PR #155735 is compliant with backport policy

Confidence: high
Critical bug criteria met: [Bugs that can cause the DB to return incorrect results or result in suboptimal performance]
Backward compatible: true
Explanation: The pull request fixes a critical bug related to the functioning of the Logical Data Replication (LDR), a product feature of CockroachDB, by addressing an issue where a database name was erroneously required in the external connection URI for bidirectional streams. The analysis determines that this change meets critical bug criteria under 'Bugs that can cause the DB to return incorrect results or result in suboptimal performance' as it deals directly with correcting the setup for bidirectional stream setups which are misconfigured due to improper privilege lookup using unqualified table names. The patch amends the method to utilize fully qualified table names, ensuring proper function of this feature. Additionally, the pull request includes a test file modification, specifically 'pkg/crosscluster/logical/logical_replication_job_test.go', which directly relates to the change and ensures the functionality works as expected after the fix. Considering the changes do not involve any backward-incompatible alterations such as removing version gates and there is no need for feature flag gating since it addresses a critical issue directly, the PR is compliant with the backport policy.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@msbutler msbutler merged commit 16c109f into cockroachdb:release-25.2 Oct 21, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-disaster-recovery target-release-25.2.8

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants