logictest: adjust a few of geo tests for s390x #148784
Open
+80
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Similar to other patches, we need to do some rounding for a couple of geo logic tests. This is the case since s390x has architecture support for trigonometric functions which are used when computing `ST_Segmentize` and `ST_Rotate` builtins. Note that the "rounding" is performed via regexp replacement on top of the textual result. Relatedly, we have a couple of tests that print inverted index keys, and for some shapes / geographies we use s2 library which also uses trigonometric functions. Thus, this commit adjusts those tests to account for the minor differences. This behavior suggests another limitation for heterogeneous clusters - we cannot guarantee to correctly read inverted geo indexes when the SQL pod and the KV / storage node run on different architectures. I don't think there is any concern for "pure" s390x clusters since they will behave consistently within the cluster. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to other patches, we need to do some rounding for a couple of geo logic tests. This is the case since s390x has architecture support for trigonometric functions which are used when computing
ST_SegmentizeandST_Rotatebuiltins. Note that the "rounding" is performed via regexp replacement on top of the textual result.Relatedly, we have a couple of tests that print inverted index keys, and for some shapes / geographies we use s2 library which also uses trigonometric functions. Thus, this commit adjusts those tests to account for the minor differences. This behavior suggests another limitation for heterogeneous clusters - we cannot guarantee to correctly read inverted geo indexes when the SQL pod and the KV / storage node run on different architectures. I don't think there is any concern for "pure" s390x clusters since they will behave consistently within the cluster.
This limitation is filed as #148783.
Fixes: #146001.
Fixes: #146007.
Fixes: #146109.
Release note: None