Skip to content

release-24.1: workload/schemachanger: apply statement_timeout out to CTAS #148774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-24.1
Choose a base branch
from

Conversation

fqazi
Copy link
Collaborator

@fqazi fqazi commented Jun 24, 2025

Backport 1/1 commits from #148761 on behalf of @fqazi.


Previously, the schema changer workload never used statement_timeouts since schema changes are normally not predictable operations. However, since we added CREATE TABLE AS support, its possible to have multiple joins where a CREATE TABLE AS can take more then 5 minutes. This patch modifies the operation generator support adding statement timeouts for individual statements.

Fixes: #148342

Release note: None


Release justification: test only change

Previously, the schema changer workload never used statement_timeouts
since schema changes are normally not predictable operations. However,
since we added CREATE TABLE AS support, its possible to have multiple
joins where a CREATE TABLE AS can take more then 5 minutes. This patch
modifies the operation generator support adding statement timeouts for
individual statements.

Fixes: cockroachdb#148342

Release note: None
@fqazi fqazi force-pushed the blathers/backport-release-24.1-148761 branch from f8e59e2 to 073a778 Compare June 24, 2025 23:18
@fqazi fqazi requested a review from a team as a code owner June 24, 2025 23:18
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 24, 2025
@fqazi fqazi requested review from herkolategan and DarrylWong and removed request for a team June 24, 2025 23:18
@blathers-crl blathers-crl bot requested review from golgeek and rafiss June 24, 2025 23:18
Copy link

blathers-crl bot commented Jun 24, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jun 24, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants