sql: ignore some session variables in RESET ALL #148770
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Looking at `src/backend/utils/misc/guc_tables.c` in PG source code, there are a few session variables flagged with `GUC_NO_RESET_ALL` that should not be affected by RESET ALL. This commit adds a `NoResetAll` flag to the following session variables that overlap with PG: - `is_superuser` - `role` - `session_authorization` - `transaction_isolation` - `transaction_read_only` This commit also adds the flag to a couple CRDB-only session variables that seem similar: - `transaction_priority` - `transaction_status` Most of these variables are read-only, and so were not affected by RESET ALL, but the new flag makes the intended behavior clear in case any of them do become writable in the future. By fixing RESET ALL, this change also makes DISCARD ALL work correctly when `default_transaction_use_follower_reads` is enabled. Fixes: cockroachdb#124150 Release note (bug fix): The RESET ALL statement is fixed to no longer affect the following session variables: - `is_superuser` - `role` - `session_authorization` - `transaction_isolation` - `transaction_priority` - `transaction_status` - `transaction_read_only` This better matches PostgreSQL behavior for RESET ALL. By fixing RESET ALL, the DISCARD ALL statement is also fixed to work correctly when `default_transaction_use_follower_reads` is enabled.
michae2
requested review from
a team,
mgartner and
yuzefovich
and removed request for
a team
rafiss
approved these changes
Jun 25, 2025
| CREATE SEQUENCE discard_seq2 START WITH 10 | ||
|
|
||
| statement ok | ||
| CREATE TEMP TABLE tempy (a int); |
There was a problem hiding this comment.
i think the DISCARD ALL from line 199 is breaking this, since it resets experimental_enable_temp_tables
There was a problem hiding this comment.
Nice! Exactly right. Running into a different problem now, will update in a bit.
yuzefovich
approved these changes
Jun 25, 2025
There was a problem hiding this comment.
Nice find!
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner and @michae2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at
src/backend/utils/misc/guc_tables.cin PG source code, there are a few session variables flagged withGUC_NO_RESET_ALLthat should not be affected by RESET ALL. This commit adds aNoResetAllflag to the following session variables that overlap with PG:is_superuserrolesession_authorizationtransaction_isolationtransaction_read_onlyThis commit also adds the flag to a couple CRDB-only session variables that seem similar:
transaction_prioritytransaction_statusMost of these variables are read-only, and so were not affected by RESET ALL, but the new flag makes the intended behavior clear in case any of them do become writable in the future.
By fixing RESET ALL, this change also makes DISCARD ALL work correctly when
default_transaction_use_follower_readsis enabled.Fixes: #124150
Release note (bug fix): The RESET ALL statement is fixed to no longer affect the following session variables:
is_superuserrolesession_authorizationtransaction_isolationtransaction_prioritytransaction_statustransaction_read_onlyThis better matches PostgreSQL behavior for RESET ALL.
By fixing RESET ALL, the DISCARD ALL statement is also fixed to work correctly when
default_transaction_use_follower_readsis enabled.