Skip to content

general: ignore vscode configuration #148747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

general: ignore vscode configuration #148747

merged 1 commit into from
Jun 25, 2025
+1 −0

Conversation

bghal
Copy link
Contributor

@bghal bghal commented Jun 24, 2025

Epic: none

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@bghal bghal requested a review from a team June 24, 2025 13:28
spilchen
spilchen approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@spilchen spilchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @bghal)

@bghal
Copy link
Contributor Author

bghal commented Jun 25, 2025

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 25, 2025

Build succeeded:

@craig craig bot merged commit b452213 into cockroachdb:master Jun 25, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spilchen spilchen spilchen approved these changes

Assignees
No one assigned
Labels
target-release-25.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bghal @cockroach-teamcity @spilchen