Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: sql: Skip constraints in pg_constraint that are being dropped. #138285

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

spilchen
Copy link
Contributor

@spilchen spilchen commented Jan 6, 2025

Backport 1/1 commits from #137860.

/cc @cockroachdb/release


When querying the pg_catalog.pg_constraint table during the process of dropping a constraint, the query could fail under certain conditions. For example, if the declarative schema changer (DSC) is in the middle of dropping a check constraint, the query could produce the following error:

ERROR: column "crdb_internal_column_2_name_placeholder" does not exist, referenced in "crdb_internal_column_2_name_placeholder IS NOT NULL" (SQLSTATE 42703)

This issue arises because, when the DSC is also dropping the column associated with the constraint, it removes the column's name from the descriptor. Consequently, any expressions referencing the column are updated with a placeholder name. While the DSC ensures that the column is no longer visible, the pg_constraint virtual table inspects the descriptor directly, encountering the placeholder name and attempting to resolve it. This fix ensures that constraints in the process of being dropped are skipped in pg_constraint, preventing such errors.

This shows up in the schema changer workload because it uses pg_constraint when building out the random op to run.

Epic: none
Closes #137513
Release note (bug fix): Fixed a bug where querying the pg_catalog.pg_constraint table while the schema changer was dropping a constraint could result in a query error.
Release justification: low-risk bug fix

@spilchen spilchen self-assigned this Jan 6, 2025
@spilchen spilchen requested a review from a team as a code owner January 6, 2025 13:44
Copy link

blathers-crl bot commented Jan 6, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jan 6, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

When querying the `pg_catalog.pg_constraint` table during the process of
dropping a constraint, the query could fail under certain conditions. For
example, if the declarative schema changer (DSC) is in the middle of dropping a
check constraint, the query could produce the following error:
```
ERROR: column "crdb_internal_column_2_name_placeholder" does not exist, referenced in "crdb_internal_column_2_name_placeholder IS NOT NULL" (SQLSTATE 42703)
```

This issue arises because, when the DSC is also dropping the column associated
with the constraint, it removes the column's name from the descriptor.
Consequently, any expressions referencing the column are updated with a
placeholder name. While the DSC ensures that the column is no longer visible,
the `pg_constraint` virtual table inspects the descriptor directly,
encountering the placeholder name and attempting to resolve it. This fix
ensures that constraints in the process of being dropped are skipped in
`pg_constraint`, preventing such errors.

This shows up in the schema changer workload because it uses pg_constraint when
building out the random op to run.

Epic: none
Closes cockroachdb#137513
Release note (bug fix): Fixed a bug where querying the
`pg_catalog.pg_constraint` table while the schema changer was dropping a
constraint could result in a query error.
@spilchen spilchen force-pushed the backport24.1-137860 branch from 69cb23d to 12c15ce Compare January 6, 2025 20:43
Copy link

blathers-crl bot commented Jan 6, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@spilchen spilchen requested a review from rafiss January 6, 2025 20:49
@spilchen spilchen merged commit 204406f into cockroachdb:release-24.1 Jan 7, 2025
19 of 20 checks passed
@spilchen spilchen deleted the backport24.1-137860 branch January 7, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants