*: use new slice to array conversion syntax #118800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvanbenschoten
requested review from
rickystewart,
a team and
abarganier
and removed request for
a team
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
rickystewart
reviewed
Feb 7, 2024
pkg/util/tracing/span.go
Outdated
| @@ -949,8 +949,8 @@ func SpanMetaFromProto(info tracingpb.TraceInfo) SpanMeta { | |||
| // NOTE: The ugly starry expressions below can be simplified once/if direct | |||
There was a problem hiding this comment.
Nit: Comment should be deleted, no?
There was a problem hiding this comment.
🤦 thanks. Done.
Closes cockroachdb#110261. This commit adopts the new slice to array conversion syntax introduced in go 1.20. The new syntax is only applicable in one small part of the codebase, so it's a small change. From https://tip.golang.org/doc/go1.20: > Go 1.20 extends this to allow conversions from a slice to an array: > given a slice x, [4]byte(x) can now be written instead of > *(*[4]byte)(x). Release note: None
nvanbenschoten
force-pushed
the
nvanbenschoten/arrayConv
branch
from
28c104c to
3116fdf
Compare
rickystewart
approved these changes
Feb 7, 2024
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #110261.
This commit adopts the new slice to array conversion syntax introduced in go 1.20. The new syntax is only applicable in one small part of the codebase, so it's a small change.
From https://tip.golang.org/doc/go1.20:
Release note: None