roachpb: deflake and unskip test make priority #110379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
kvoli
force-pushed
the
230911.deflake-make-priority
branch
from
9bec2d9 to
08518e6
Compare
`TestMakePriority` was skipped in cockroachdb#110354 due to flakes. The test began to flake after upgrading to `go1.20` in cockroachdb#109773, as the global rand was seeded differently. Bump the number of trials from 100k to 750k in order to collect more samples of the underlying distribution, which deflakes the test. This doubles the average test time, from 200ms to 400ms on a GCP C2 instance. Passes 50k runs: ``` dev test pkg/roachpb -f TestMakePriority -v --stress --count=50000 ... //pkg/roachpb:roachpb_test PASSED in 0.9s Stats over 50000 runs: max = 0.9s, min = 0.3s, avg = 0.4s, dev = 0.0s ``` Fixes: cockroachdb#110303 Release note: None
kvoli
force-pushed
the
230911.deflake-make-priority
branch
from
08518e6 to
ddf7669
Compare
arulajmani
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Solid deflaking!
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)
nvanbenschoten
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:
|
TYFTR! bors r=arulajmani,nvanbenschoten |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestMakePrioritywas skipped in #110354 due to flakes. The test beganto flake after upgrading to
go1.20in #109773, as the global rand wasseeded differently.
Bump the number of trials from 100k to 750k in order to collect more
samples of the underlying distribution, which deflakes the test. This
doubles the average test time, from 200ms to 400ms on a GCP C2 instance.
Passes 50k runs:
Fixes: #110303
Release note: None