Use native driver #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase real quick for me. |
Yep |
I don't think there was anything to rebase because it was already based off of |
|
Can you try again. It says there's 2 commits and the first one is already merged into
|
This is now a required prop and was causing warnings in React Native.
jarod-legault
force-pushed
the
useNativeDriver
branch
from
394bee9 to
c2545fe
Compare
|
Ok. Worked this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing a warning in React Native because
useNativeDriveris a required prop inAnimated.timingnow.Someone else already created PR #222 to address this issue on the parent project.
This branch is based off of the
fix_react_native_warningsbranch, so #1 should be merged before this PR.