Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat select input files and workspace path #8

Merged
merged 22 commits into from
Aug 16, 2024

Conversation

brnovasco
Copy link
Collaborator

@brnovasco brnovasco commented Jul 29, 2024

This pr resolves #3.

  1. Add new base ui components needed for the file navigation component ("nautilus");
  2. Create component for rendering remote file navigation based on an "ls-like" api response;
  3. Add component as form input for image, label, superpixel, annotation file paths and output dir path to the new instance form;
  4. Create api route performing ls via ssh;
  5. Refactor job script template for creating env variables based on the new form fields and passing it to the container environment on runtime;
  6. Refactor api route for submitting the job with the new fields replacing the associated variables in the script template;

Requires changes in the .env file.

@brnovasco brnovasco added the enhancement New feature or request label Jul 29, 2024
@brnovasco brnovasco marked this pull request as draft July 31, 2024 16:40
@brnovasco
Copy link
Collaborator Author

brnovasco commented Jul 31, 2024

New navigation input field requested for "class model" file. Waiting for tests with new container.

@brnovasco brnovasco marked this pull request as ready for review August 14, 2024 16:24
RafaelLyra8
RafaelLyra8 previously approved these changes Aug 15, 2024
@brnovasco
Copy link
Collaborator Author

brnovasco commented Aug 16, 2024

Hi, @RafaelLyra8! Thanks for the review! I think the merge was still blocked because our team was not assigned as maintainer for this repo. I think I solved this now. I also took the opportunity to solve other small issue related to error messages breaking the layout of the form when I presented these changes in our last meeting.

@brnovasco brnovasco requested a review from RafaelLyra8 August 16, 2024 18:10
@brnovasco brnovasco self-assigned this Aug 16, 2024
@brnovasco brnovasco merged commit 5a323d9 into main Aug 16, 2024
3 checks passed
@brnovasco brnovasco deleted the feat-select-input-files-and-workspace-path branch August 16, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigate remote storage and select file paths passing it as environment variables to the job
2 participants