Use logFileName static buffer directly #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditionally allocating memory for log_file_path leads to a bug when logging is disabled because pimegaDetector::setDefaults() will later attempt to set the PimegaLogFile parameter based on this uninitialized member. Considering that this was introduced by the fixed commit which aims at hiding the struct fields, and that such hinding no longer makes sense, simply revert to the original approach of using logFileName directly. Fixes: 0d94f9e (Removed direct pimega pointer calls, 2024-02-23)
Hi! Could you please explain why does it no longer makes sense? |
Because we published ADPimega with the entire git history, so anyone can see what members of struct pimega exist. The commit that this PR fixes was hiding direct accesses to the pimega struct with the intention to publish a repository without any history, which we gave up on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally allocating memory for log_file_path leads to a bug when logging is disabled because pimegaDetector::setDefaults() will later attempt to set the PimegaLogFile parameter based on this uninitialized member. Considering that this was introduced by the fixed commit which aims at hiding the struct fields, and that such hinding no longer makes sense, simply revert to the original approach of using logFileName directly.
Fixes: 0d94f9e (Removed direct pimega pointer calls, 2024-02-23)
Fixes #6