v3.4 alternative #19
Open
v3.4 alternative #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The precision of AcquireTime and AcquireTime_RBV is set to 3 by ADBase, which is not enough to represent the minimum acquire time available (0.0005). This commit increases the precision of AcquireTime_RBV to 6 decimal places, which is the same value already used by AcquireTime.
There's no need for it to be a class member, it's only used inside a single function.
Open
The high perf stream sends 16-bit data for 12-bit images, and 32-bit data for 24-bit images, so updateEpicsFrames needed to be updated to deal with that. Accessing PimegaCounterDepth in the zmq callback without locking the port is safe, because the value can't be updated while an acquisition is happening, which is when the frames are received. It's important to note that this change requires changing the BackendPortFrame argument to pimegaDetectorConfig to match "stream_port" from backend.json. This breaks the DACCountScan implementation, because it depends on the port being passed to it having the "pimega_frame_visualizer" subscription available. This issue isn't dealt with here, because the DACCountScan implementation in the IOC is already broken for other reasons. Co-authored-by: Érico Nogueira <[email protected]>
This is necessary in order to allow building on Ubuntu 24.04, since this version includes workarounds for issues with FORTIFY_SOURCE.
ADSDKVersion wasn't filled in because pimega-api doesn't provide version runtime. We obtain the driver version from git. Co-authored-by: Érico Nogueira <[email protected]> Co-authored-by: Henrique F. Simoes <[email protected]> Tested-by: Henrique F. Simoes <[email protected]>
This function is called by the Capture function and it didn't return anything. Other GCC versions may ignore this lack of return but on GCC 13.3.0 (Ubuntu 13.3.0-6ubuntu2~24.04) this causes a sigill and crashes the software.
Co-authored-by: Érico Nogueira <[email protected]>
ericonr
force-pushed
the
v3.4-alternative
branch
from
40e36b0 to
9d21ddc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #18