Add support for (Linux) net device injection. by klihub · Pull Request #269 · cncf-tags/container-device-interface

klihub · 2025-04-09T13:29:17Z

This PR adds support for injecting Linux NetDevices to an OCI Spec. In particular, the PR

adds NetDevices to ContainerEdits in the CDI Spec
implements network device injection to the OCI Spec
bumps the CDI Spec version to 1.1.0
updates JSON schema with NetDevices
adds CDI Spec version validation to the cmd/cdi test/cli binary
updates SPEC.md with info about NetDevices
updates SPEC.md with info about recent RDT changes
updates JSON schema to reflect recent RDT changes

specs-go/version.go

specs-go/config.go

pkg/cdi/container-edits.go

github-actions · 2025-07-10T04:32:13Z

This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label.

elezar · 2025-08-07T13:57:24Z

@klihub is there a version of the OCI runtime spec that includes these fields now? Could we update this PR so that we can look at pushing out a v1.1.0 of the spec together with the changes from #278 and #279?

klihub · 2025-08-07T14:06:58Z

@klihub is there a version of the OCI runtime spec that includes these fields now?

@elezar Not with a tagged version yet, unfortunately.

Could we update this PR so that we can look at pushing out a v1.1.0 of the spec together with the changes from #278 and #279?

I think we don't need to wait for this to get merged to tag a new version. We can tag a release without this right away, if everything else has been already merged. But we can't merge #279 yet, for the same reason. intelRdt.enableMonitoring is not available yet in a tagged version of the OCI Spec.

elezar · 2025-11-05T10:58:34Z

It seems as if the v1.3.0 spec has been tagged.

klihub · 2025-11-07T10:13:11Z

It seems as if the v1.3.0 spec has been tagged.

Yes, but I think we'll need for opencontainers/runtime-tools#795 (and opencontainers/runtime-tools#797) to get merged.

bart0sh · 2025-11-17T08:27:23Z

@klihub lgtm. Do we need to update/add any tests for the new fields?

.github/workflows/sanity.yml

klihub · 2025-11-17T09:19:23Z

@klihub lgtm. Do we need to update/add any tests for the new fields?

@bart0sh Yes, I think we'd need those and they are missing now. I'll add them.

klihub · 2025-11-25T08:20:19Z

Ping @elezar, PTAL.

pkg/cdi/container-edits.go

specs-go/config.go

pkg/cdi/container-edits.go

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

Implement OCI Spec (Linux) NetDevice injection. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

Bump current version to 1.1.0, include net devices in minimum required version check. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

specs-go/version.go

specs-go/config.go

elezar

@klihub this looks good now.

Some minor questions regarding whether this should include edits to SPEC.md, but I am approving this provisionally.

Update spec description, adding net devices and updating RDT to reflect recent changes. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

klihub · 2025-12-10T07:09:15Z

@klihub this looks good now.

Some minor questions regarding whether this should include edits to SPEC.md, but I am approving this provisionally.

@elezar Added 1 extra commits to update SPECS.md for NetDevices and the recent RDT changes, to sync the JSON schema with the recent RDT changes, and to add clarifying 'Added in' comments for the recently added RDT fields.

…lds. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

elezar · 2025-12-10T08:09:50Z

specs-go/version.go

 		}
 	}

+	if len(spec.ContainerEdits.NetDevices) != 0 {


This really is a big nit: At other places where we're checking non-empty, we explicilty check > 0 and not != 0. Not going to block on this though.

elezar

Thanks @klihub. This looks good now.

Do you want to wait on a review from @bart0sh or @marquiz before I merge?

klihub force-pushed the devel/linux-net-device branch 3 times, most recently from 658b35b to 9900940 Compare April 9, 2025 13:37