Skip to content

Fixed default date for the particular indicator(signal) dashboard #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 20, 2025

Conversation

dmytrotsko
Copy link
Contributor

@dmytrotsko dmytrotsko commented Oct 23, 2024

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

Fixed: When particular indicator(signal) dashboard page was opened, the date was inherited from the "main page".

@dmytrotsko dmytrotsko self-assigned this Oct 23, 2024
Copy link

netlify bot commented Oct 23, 2024

Preview link ready!

Name Link
🔨 Latest commit 613ea13
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/67dc385d8fd69800087d622e
😎 Deploy Preview https://deploy-preview-1263--cmu-delphi-covidcast.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dmytrotsko dmytrotsko requested a review from melange396 March 19, 2025 18:30
@melange396 melange396 linked an issue Mar 20, 2025 that may be closed by this pull request
Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is beautiful!

The CI stuff should succeed/pass if you merge the dev branch into this PR's branch (or i think you can kinda "cheat" by instead editing the PR description to change the base branch away from dev, save, then edit to change the base branch back to dev -- im gonna try that in a moment).

@melange396 melange396 changed the base branch from dev to staging March 20, 2025 02:40
@melange396 melange396 changed the base branch from staging to dev March 20, 2025 02:40
@melange396
Copy link
Contributor

whoops, i was wrong -- i was thinking of a different repo where i made changes to fix this same problem. ill do the update in this repo too.

@melange396
Copy link
Contributor

@melange396 melange396 changed the base branch from dev to staging March 20, 2025 15:42
@melange396 melange396 changed the base branch from staging to dev March 20, 2025 15:42
melange396 and others added 5 commits March 20, 2025 17:46
Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.21.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md)
- [Commits](expressjs/express@4.19.2...4.21.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [webpack](https://github.com/webpack/webpack) from 5.76.0 to 5.97.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.76.0...v5.97.1)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@melange396 melange396 merged commit 4447ab4 into dev Mar 20, 2025
6 checks passed
@melange396 melange396 deleted the signal_dashboard_default_date_fix branch March 20, 2025 15:50
@melange396 melange396 mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"latest known data" link does not preserve context
2 participants