add epix_slide example comparing same computation with all_vers FALSE #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookslogan
approved these changes
May 8, 2023
There was a problem hiding this comment.
I eliminated a warning from min(x$DT$version) and added some more commentary. (The special strings we have for 0-row inputs don't show up now due to the recycling rules, but will appear in combination with #311.)
(GitHub isn't running checks on the dev branch; running checks locally, I only see irrelevant errors. I think I have the auto checks enabled for dev in #311 along with fixes for some of these irrelevant check errors/warnings.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add example to
epix_slidedocumentation comparing the same computation forall_versions = TRUEandall_versions = FALSE.