Skip to content

deleted *.php from /server and docs, deleted Dockerfile #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Conversation

BrainIsDead
Copy link
Contributor

closes 1001

Summary

Deleted *.php files from /server dir and docs, deleted Dockerfile related to php files

@BrainIsDead BrainIsDead linked an issue Feb 22, 2023 that may be closed by this pull request
@BrainIsDead BrainIsDead requested review from christymelucci, melange396 and rzats and removed request for christymelucci February 22, 2023 15:08
@BrainIsDead
Copy link
Contributor Author

@melange396 @rzats there are cdc_upload.php, dasboard.php and master.php in ./src/acquisition/*/*:

  • cdc_upload.php meets once in /delphi-epidata/deploy.json
  • dashboard.php should be available by the link https://delphi.cmu.edu/~automation/public/wiki/ but it returns 404 for me, also meets in /delphi-epidata/deploy.json
  • master.php is for rearing wiki_raw table independently and in parallel to wiki_download.py, and looks loke exists in wiki_download as MASTER_URL = 'https://delphi.cmu.edu/~automation/public/wiki/master.php' (but link returns 404 for me). Also meets in /delphi-epidata/deploy.json

Not sure what I should to do with these files

Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding ./src/acquisition/*/*.php, those should be deleted as well (and the references in deploy.json, of course). We havent had anything running them for a long time, so they will not be missed.

Could you also update docs/epidata_development.md to remove references to the delphi_web image, and update the delphi_web_epidata image build statement from the Dockerfile being deleted in this PR to the current proper Dockerfile location (as in the dev Makefile)? There are other anachronisms in that file, but i would say we can leave them alone for now.

@BrainIsDead BrainIsDead marked this pull request as ready for review February 24, 2023 14:44
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! i am very glad to see this stuff disappear!!!

@melange396 melange396 merged commit 510e31f into dev Feb 24, 2023
@melange396 melange396 deleted the issue_1001 branch February 24, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove vestiges of PHP
2 participants