Skip to content

Bump Pandas to 1.5.1 #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Bump Pandas to 1.5.1 #1045

wants to merge 2 commits into from

Conversation

@dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Dec 5, 2022 •
edited
Loading

This is required by #646.

Built on #1044.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

JIT requires a more recent Pandas version. Not exactly sure which one, but I've tested it with pandas==1.5.1. Want to separate this bump from JIT, for easier debugging.

TODO:

  • Look through all usages of Pandas and double check no interfaces have changed (especially the parts not covered by unit tests)

@dshemetov dshemetov changed the base branch from dev to ds/covidcast-row December 5, 2022 21:34
@dshemetov dshemetov mentioned this pull request Dec 5, 2022
Draft
27 tasks
@dshemetov dshemetov force-pushed the ds/covidcast-row branch 2 times, most recently from ec5c6c6 to 163185f Compare December 6, 2022 00:33
krivard
krivard previously approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dshemetov dshemetov force-pushed the ds/covidcast-row branch 4 times, most recently from 3bcc0cb to 703d57c Compare January 21, 2023 14:32
@dshemetov dshemetov force-pushed the ds/covidcast-row branch 2 times, most recently from 183187a to b3cba4c Compare February 5, 2023 00:56
Base automatically changed from ds/covidcast-row to dev February 6, 2023 15:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@melange396
Copy link
Collaborator

melange396 commented Jun 29, 2024

might as well go to 1.5.3, which is the latest before 2.0

@melange396 melange396 changed the base branch from dev to main June 29, 2024 02:08
@melange396 melange396 changed the base branch from main to dev June 29, 2024 02:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@melange396
Copy link
Collaborator

melange396 commented Jun 29, 2024

this may also resolve #992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@krivard krivard krivard left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dshemetov @melange396 @krivard