Skip to content

Add NAN code support to CAN#989

Closed
dshemetov wants to merge 2 commits intocmu-delphi:mainfrom
dshemetov:nans_covidactnow
Closed

Add NAN code support to CAN#989
dshemetov wants to merge 2 commits intocmu-delphi:mainfrom
dshemetov:nans_covidactnow

Conversation

@dshemetov
Copy link
Copy Markdown
Contributor

@dshemetov dshemetov commented Apr 7, 2021

Description

Work as part #838. Branched off #1252, so that one should be merged first.

Changelog

  • Add three missingness columns, default to NA for "sample_size" and "stderr" columns, depending on the signal

Fixes

@dshemetov dshemetov mentioned this pull request Apr 7, 2021
17 tasks
@dshemetov dshemetov requested a review from jingjtang September 15, 2021 21:52
dshemetov and others added 2 commits October 19, 2021 11:54
* add missing columns, allow nan values through
Copy link
Copy Markdown
Contributor

@jingjtang jingjtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dshemetov
Copy link
Copy Markdown
Contributor Author

dshemetov commented Nov 9, 2021

Bumping this PR. @krivard

@krivard
Copy link
Copy Markdown
Contributor

krivard commented Nov 10, 2021

Nothing risky until after we're clear of the JHU patch next week, which probably means after Thanksgiving 😞

@dshemetov dshemetov closed this by deleting the head repository May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants