-
Notifications
You must be signed in to change notification settings - Fork 17
Clean up delphi_utils #1984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up delphi_utils #1984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the right track, thanks! Can you please also
- adjust the bumpversion.cfg file to replace setup.py with pyproject.toml
- update the release command in the Makefile to do
python -m build --sdist --wheel
- and update this CI line to
pip install build pylint pytest pydocstyle wheel twine
- update this install line to
pip install -e .[dev]
- remove
setup.py
- update the unit test install line in
DEVELOP.md
topip install -e .[dev]
Would also appreciate if you can sanity check some of these commands locally.
a8c2340
to
c4cc418
Compare
c4cc418
to
7eaf30f
Compare
1e3a39b
to
a38e080
Compare
release diff: STR:
result
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Tests pass, so we can be confident our indicators will continue to work. Amaris tested the release command as well and the artifacts didn't have any unexpected changes. I double checked that all the dependencies have been moved from setup.py over to pyproject.toml.
Co-authored-by: Dmitry Shemetov <[email protected]>
Description
migrating setup.py to pyproject.toml and cleaning up dependencies
Changelog
Itemize code/test/documentation changes and files added/removed.
Fixes