Skip to content

Clean up delphi_utils #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 24, 2024
Merged

Clean up delphi_utils #1984

merged 10 commits into from
Jul 24, 2024

Conversation

aysim319
Copy link
Contributor

@aysim319 aysim319 commented Jul 1, 2024

Description

migrating setup.py to pyproject.toml and cleaning up dependencies

Changelog

Itemize code/test/documentation changes and files added/removed.

  • added pyproject.toml

Fixes

@aysim319 aysim319 requested review from dshemetov and minhkhul July 1, 2024 19:25
Copy link
Contributor

@dshemetov dshemetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the right track, thanks! Can you please also

  • adjust the bumpversion.cfg file to replace setup.py with pyproject.toml
  • update the release command in the Makefile to do python -m build --sdist --wheel
  • and update this CI line to pip install build pylint pytest pydocstyle wheel twine
  • update this install line to pip install -e .[dev]
  • remove setup.py
  • update the unit test install line in DEVELOP.md to pip install -e .[dev]

Would also appreciate if you can sanity check some of these commands locally.

@aysim319 aysim319 force-pushed the 1973-clean-up-delphi_utils branch 2 times, most recently from a8c2340 to c4cc418 Compare July 8, 2024 22:52
@aysim319 aysim319 force-pushed the 1973-clean-up-delphi_utils branch from c4cc418 to 7eaf30f Compare July 22, 2024 14:25
@aysim319 aysim319 force-pushed the 1973-clean-up-delphi_utils branch from 1e3a39b to a38e080 Compare July 22, 2024 14:51
@aysim319
Copy link
Contributor Author

release diff:

STR:

  • run make release in this branch
    • rename dist to dist_new
  • run make release in main
  • unzip both tar
  • in Mac ` diff -rq dist/delphi_utils-xxxx dist_new/delphi_utils-yyyy
    • the versioning might be off

result

Files dist/delphi_utils-0.3.24/.bumpversion.cfg and dist_new/delphi_utils-0.3.23/.bumpversion.cfg differ
Files dist/delphi_utils-0.3.24/DEVELOP.md and dist_new/delphi_utils-0.3.23/DEVELOP.md differ
-> command changed reflected in PR
Files dist/delphi_utils-0.3.24/Makefile and dist_new/delphi_utils-0.3.23/Makefile differ
-> commands change reflected in the PR
Files dist/delphi_utils-0.3.24/PKG-INFO and dist_new/delphi_utils-0.3.23/PKG-INFO differ
-> package info changed reflected in PR
Files dist/delphi_utils-0.3.24/delphi_utils/.DS_Store and dist_new/delphi_utils-0.3.23/delphi_utils/.DS_Store differ
Files dist/delphi_utils-0.3.24/delphi_utils/data/.DS_Store and dist_new/delphi_utils-0.3.23/delphi_utils/data/.DS_Store differ
Files dist/delphi_utils-0.3.24/delphi_utils.egg-info/PKG-INFO and dist_new/delphi_utils-0.3.23/delphi_utils.egg-info/PKG-INFO differ
Files dist/delphi_utils-0.3.24/delphi_utils.egg-info/SOURCES.txt and dist_new/delphi_utils-0.3.23/delphi_utils.egg-info/SOURCES.txt differ
Files dist/delphi_utils-0.3.24/delphi_utils.egg-info/requires.txt and dist_new/delphi_utils-0.3.23/delphi_utils.egg-info/requires.txt differ
Only in dist_new/delphi_utils-0.3.23: pyproject.toml
Only in dist/delphi_utils-0.3.24: setup.py

Copy link
Contributor

@dshemetov dshemetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Tests pass, so we can be confident our indicators will continue to work. Amaris tested the release command as well and the artifacts didn't have any unexpected changes. I double checked that all the dependencies have been moved from setup.py over to pyproject.toml.

@aysim319 aysim319 merged commit 13de21a into main Jul 24, 2024
16 checks passed
@aysim319 aysim319 deleted the 1973-clean-up-delphi_utils branch July 24, 2024 16:17
@dshemetov dshemetov mentioned this pull request Jul 25, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up delphi_utils
2 participants