DB Rework for Quest 7631 - Dreadsteed of Xoroth (Warlock Mount Quest) #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing emote dialog when demons unsummon - Make script NPC invisible - Remove `creature_movement_template` entries that produce bad movement (handled in cpp scripting now) - Tweaked wave spawn timers
AnonXS
reviewed
May 11, 2024
| @@ -0,0 +1,157 @@ | |||
| -- missing emote dialog | |||
| INSERT INTO `script_texts` (`entry`, `content_default`, `sound`, `type`, `language`, `emote`, `broadcast_text_id`, `comment`) | |||
There was a problem hiding this comment.
script_texts is obsolete and does not belong into db repo
AnonXS
reviewed
May 11, 2024
| -- missing emote dialog | ||
| INSERT INTO `script_texts` (`entry`, `content_default`, `sound`, `type`, `language`, `emote`, `broadcast_text_id`, `comment`) | ||
| VALUES ('-1429005', '%s is pulled back to Xoroth!', '0', '2', '0', '0', '10063', 'Xoroth demon unsummoned'); | ||
| INSERT INTO `broadcast_text` (`Id`, `Text`, `Text1`, `ChatTypeID`, `LanguageID`, `ConditionID`, `EmotesID`, `Flags`, `SoundEntriesID1`, `SoundEntriesID2`, `EmoteID1`, `EmoteID2`, `EmoteID3`, `EmoteDelay1`, `EmoteDelay2`, `EmoteDelay3`, `VerifiedBuild`) |
AnonXS
reviewed
May 11, 2024
| UPDATE `creature_template` SET `ExtraFlags` = 128 WHERE `Entry` = 14501; | ||
|
|
||
| -- produces janky movement, removing to handle in script | ||
| DELETE FROM `creature_movement_template` WHERE `Entry` IN (14482, 14483); |
There was a problem hiding this comment.
most of this and following data should be in instance file, so it can be properly diffed..
AnonXS
reviewed
May 11, 2024
| VALUES ('10063', '%s is pulled back to Xoroth!', '', '2', '0', '0', '0', '1', '0', '0', '0', '0', '0', '0', '0', '0', '31882'); | ||
|
|
||
| -- make DND creature invisible | ||
| UPDATE `creature_template` SET `ExtraFlags` = 128 WHERE `Entry` = 14501; |
There was a problem hiding this comment.
Faction seems to be 90, isnt there a better solution then adding 128 as extraflag?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creature_movement_templateentries that produce bad movement (handled in cpp scripting now)