-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the declaring the type as it is deprecated #79
base: master
Are you sure you want to change the base?
Conversation
This is resolve cmanaha#76 (Specifying types in bulk requests is deprecated) which results in the following warning. ElasticsearchDeprecationWarning: [types removal] Specifying types in bulk requests is deprecated.
@cmanaha are there any comments or needs to get this pull request accepted? |
Would be great to have this merged. This change works for me. |
+1 would be great to have those issue resolved |
Can we get this merged, please? |
Has anyone heard from the project leader? |
Hey @werebear73 The original author (Carlos) and I talked a few weeks ago and he gave me the permissions to help bring the code and package up to date for everyone. Can we setup a meeting this week to review your merge request again? 🤓 Adrian |
Sure |
How about tomorrow at 8am PDT for you and anyone else that wants to chat? 8pm PDT or during the workday is good for me too. If tomorrow works we can use this Chime meeting info:
|
The real question is whether it makes sense to try to fix this project when there's ECS-compliant alternative which seems to be maintained: https://github.com/IMInterne/python-elasticsearch-ecs-logger. I moved all my projects to it and it was mostly plug-and-play replacement and besides following ECS schema it also fixed quite a few bugs on the way, including some log messages getting lost on their way to Elasticsearch. |
Reopened after decision with Adrian |
Maybe, we could solve this problem by passing a None value to type field es_doc_type |
This is resolve #76 (Specifying types in bulk requests is deprecated) which results in the following warning.
ElasticsearchDeprecationWarning: [types removal] Specifying types in bulk requests is deprecated.