Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the declaring the type as it is deprecated #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

werebear73
Copy link

This is resolve #76 (Specifying types in bulk requests is deprecated) which results in the following warning.

ElasticsearchDeprecationWarning: [types removal] Specifying types in bulk requests is deprecated.

This is resolve cmanaha#76 (Specifying types in bulk requests is deprecated) which results in the following warning.

ElasticsearchDeprecationWarning: [types removal] Specifying types in bulk requests is deprecated.
@werebear73
Copy link
Author

@cmanaha are there any comments or needs to get this pull request accepted?

@javiermatos
Copy link

Would be great to have this merged. This change works for me.

@simonjk
Copy link

simonjk commented Nov 17, 2020

+1 would be great to have those issue resolved

@martinschi
Copy link

Can we get this merged, please?

@werebear73
Copy link
Author

Has anyone heard from the project leader?

@werebear73 werebear73 closed this Sep 21, 2021
@drumadrian
Copy link
Collaborator

Hey @werebear73

The original author (Carlos) and I talked a few weeks ago and he gave me the permissions to help bring the code and package up to date for everyone.

Can we setup a meeting this week to review your merge request again? 🤓

Adrian

@werebear73
Copy link
Author

Sure

@drumadrian
Copy link
Collaborator

How about tomorrow at 8am PDT for you and anyone else that wants to chat?

8pm PDT or during the workday is good for me too.

If tomorrow works we can use this Chime meeting info:

You have been invited to an online meeting, powered by Amazon Chime.

Click to join the meeting: https://chime.aws/2764064532
Meeting ID: 2764 06 4532
A headset is recommended or you may use your computer’s microphone and speakers.

Call in using your phone:
United States Toll-Free (1): +1 855-552-4463
Meeting ID: 2764 06 4532
One-click Mobile Dial-in (United States (1)): +1 206-462-5569,,,2764064532#
United States (1): +1 206-462-5569
International: https://chime.aws/dialinnumbers/
Dial-in attendees must enter *7 to mute or unmute themselves.

Download Amazon Chime at https://aws.amazon.com/chime/download
For information about creating an Amazon Chime account, see https://aws.amazon.com/chime/getting-started

@martinschi
Copy link

The real question is whether it makes sense to try to fix this project when there's ECS-compliant alternative which seems to be maintained: https://github.com/IMInterne/python-elasticsearch-ecs-logger. I moved all my projects to it and it was mostly plug-and-play replacement and besides following ECS schema it also fixed quite a few bugs on the way, including some log messages getting lost on their way to Elasticsearch.

@werebear73
Copy link
Author

Reopened after decision with Adrian

@werebear73 werebear73 reopened this Sep 22, 2021
@elijahxb
Copy link

elijahxb commented May 4, 2022

Maybe, we could solve this problem by passing a None value to type field es_doc_type
just like this:
CMRESHandler(xxx=xxx, es_doc_type=None)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specifying types in bulk requests is deprecated
6 participants