Skip to content

Fix #839: Prefix review-comment commands with "Codev:"#864

Merged
amrmelsayed merged 7 commits into
mainfrom
builder/bugfix-839
May 26, 2026
Merged

Fix #839: Prefix review-comment commands with "Codev:"#864
amrmelsayed merged 7 commits into
mainfrom
builder/bugfix-839

Conversation

@amrmelsayed
Copy link
Copy Markdown
Collaborator

Summary

Two entries in packages/vscode/package.json#contributes.commands were missing the Codev: prefix that every other command in the extension uses. On the VS Code Feature Contributions tab they appeared as if they came from a different extension. This PR renames the two titles to match the existing title-cased convention (Codev: Open Builder Terminal, Codev: Approve Gate, …).

Fixes #839

Root Cause

codev.submitReviewComment and codev.deleteReviewComment were declared with titles "Submit review comment" and "Delete review comment". Both are hidden from the Command Palette via menus.commandPalette { when: false } (they target the comment-thread gutter), but the Feature Contributions tab lists every declared command regardless — exposing the inconsistency.

Fix

packages/vscode/package.json:

  • codev.submitReviewComment: "Submit review comment""Codev: Submit Review Comment"
  • codev.deleteReviewComment: "Delete review comment""Codev: Delete Review Comment"

Audited all 40 contributes.commands entries — every entry now starts with Codev:. No other files reference these title strings (commands are wired up by command id, not title).

Test Plan

  • Build passes (pnpm build)
  • All tests pass (porch checks green)
  • Audited every contributes.commands entry — all 40 now Codev:-prefixed
  • No regression test: the change is a static manifest entry surfaced by VS Code's marketplace UI; there is no runtime code path to assert against. The static audit above is the equivalent check.

Two contributes.commands entries in packages/vscode/package.json were
missing the "Codev:" prefix used by every other declared command,
making them look like they came from a different extension in the
VS Code Feature Contributions tab.

- codev.submitReviewComment: "Submit review comment" -> "Codev: Submit Review Comment"
- codev.deleteReviewComment: "Delete review comment" -> "Codev: Delete Review Comment"

All 40 entries on the Feature Contributions command list now start with "Codev:".
@amrmelsayed
Copy link
Copy Markdown
Collaborator Author

Architect Review

Low-risk change. Surgical 2-line manifest fix in packages/vscode/package.jsoncodev.submitReviewComment and codev.deleteReviewComment now carry the Codev: prefix matching the other 38 contributed commands. CMAP unanimous (gemini=APPROVE, codex=APPROVE, claude=APPROVE).

Verified:

  • The diff matches the issue body exactly — no scope creep
  • All 40 contributed commands now consistently prefixed
  • Static manifest entries, no runtime path to test against
  • No callers reference the title text (commands wired by id)

Approved. Please merge.


Architect review

@amrmelsayed amrmelsayed merged commit 4ec1679 into main May 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review comment commands missing 'Codev:' prefix in Feature Contributions tab

1 participant