fix: remove dependency on derivative #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
flaneur2020
changed the title
flaneur2020
force-pushed
the
chore/remove-derivative
branch
from
6f47efa to
d5255ab
Compare
|
Thanks very much for your contribution! |
PureWhiteWu
previously approved these changes
Jan 2, 2025
Millione
reviewed
Jan 2, 2025
Millione
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fixes #293
Solution
the
derivativecrate has been marked as unmaintained by a GitHub bot, and all repositories depending onpilotahave received a warning issue regarding this.this PR removes the dependency on
derivativeby using the#[derive(Default)]attribute from the Rust stdlib for unit enum variants. and manually generatedimpl Defaultfor enums with non-unit variants (e.g.,Ok(String)).