-
Notifications
You must be signed in to change notification settings - Fork 493
WIP: perf: replace mcache with pcache #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joway
wants to merge
4
commits into
develop
Choose a base branch
from
perf/pcache
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,210 @@ | ||
| package netpoll | ||
|
|
||
| import ( | ||
| "log" | ||
| "math/bits" | ||
| "reflect" | ||
| "runtime" | ||
| "unsafe" | ||
| _ "unsafe" | ||
| ) | ||
|
|
||
| //go:linkname procPin runtime.procPin | ||
| func procPin() int | ||
|
|
||
| //go:linkname procUnpin runtime.procUnpin | ||
| func procUnpin() int | ||
|
|
||
| var globalPCache = newPCache() | ||
|
|
||
| func Malloc(size int, capacity ...int) []byte { | ||
| return globalPCache.Malloc(size, capacity...) | ||
| } | ||
|
|
||
| func Free(buf []byte) { | ||
| globalPCache.Free(buf) | ||
| } | ||
|
|
||
| const ( | ||
| debug = false | ||
| defaultPCacheMaxSize = 42 // 2^42=4 TB | ||
| defaultPCacheBlockSize = 1024 * 1024 * 16 | ||
| defaultPCacheCleanCycles = 3 | ||
| ) | ||
|
|
||
| type pcache struct { | ||
| arena []byte // fixed size continuous memory | ||
| arenaStart uintptr // arena address start | ||
| arenaEnd uintptr // arena address end | ||
| activeBlocks [][]byte // [pid][]byte | ||
| inactiveBlocks [][]byte // [pid][]byte | ||
| active [][defaultPCacheMaxSize][][]byte // [pid][cap_idx][idx]stack | ||
| inactive [][defaultPCacheMaxSize][][]byte // [pid][cap_idx][idx]stack | ||
| ref *pcacheRef // for gc trigger | ||
| } | ||
|
|
||
| type pcacheRef struct { | ||
| pc *pcache | ||
| gc int | ||
| } | ||
|
|
||
| func gcRefHandler(ref *pcacheRef) { | ||
| defer runtime.SetFinalizer(ref, gcRefHandler) | ||
| ref.gc++ | ||
| if ref.gc < defaultPCacheCleanCycles { | ||
| return | ||
| } | ||
| ref.gc = 0 | ||
|
|
||
| // trigger handler | ||
| pid := procPin() | ||
| var buf [][]byte | ||
| var l, c, released int | ||
| for i := 0; i < defaultPCacheMaxSize; i++ { | ||
| l = len(ref.pc.inactive[pid][i]) | ||
| if l == 0 { | ||
| continue | ||
| } | ||
| c = 1 << i | ||
| buf = make([][]byte, l/2, l) | ||
| copy(buf, ref.pc.inactive[pid][i][:l/2]) // the first l/2 items are more inactive | ||
| ref.pc.inactive[pid][i] = buf | ||
| released += c * len(buf) | ||
| } | ||
| procUnpin() | ||
| if debug && released > 0 { | ||
| log.Printf("PCACHE: P[%d] release: %d bytes", pid, released) | ||
| } | ||
| } | ||
|
|
||
| func newPCache() *pcache { | ||
| return newLimitedPCache(defaultPCacheBlockSize * runtime.GOMAXPROCS(0)) | ||
| } | ||
|
|
||
| func newLimitedPCache(size int) *pcache { | ||
| procs := runtime.GOMAXPROCS(0) | ||
| sizePerP := size / procs | ||
| pc := &pcache{ | ||
| activeBlocks: make([][]byte, procs), | ||
| inactiveBlocks: make([][]byte, procs), | ||
| active: make([][defaultPCacheMaxSize][][]byte, procs), | ||
| inactive: make([][defaultPCacheMaxSize][][]byte, procs), | ||
| } | ||
|
|
||
| // init arena | ||
| pc.arena = make([]byte, size) | ||
| pc.arenaStart = uintptr(unsafe.Pointer(&pc.arena[0])) | ||
| pc.arenaEnd = uintptr(unsafe.Pointer(&pc.arena[len(pc.arena)-1])) | ||
| for i := 0; i < procs; i++ { | ||
| pc.activeBlocks[i] = pc.arena[i*sizePerP : (i+1)*sizePerP] | ||
| } | ||
|
|
||
| pc.ref = &pcacheRef{pc: pc} | ||
| runtime.SetFinalizer(pc.ref, gcRefHandler) | ||
| pc.ref = nil // trigger gc | ||
| return pc | ||
| } | ||
|
|
||
| func (p *pcache) Malloc(size int, _capacity ...int) (data []byte) { | ||
| var capacity = size | ||
| if len(_capacity) > 0 && _capacity[0] > size { | ||
| capacity = _capacity[0] | ||
| } | ||
| cidx := calcCapIndex(capacity) | ||
| clen := 1 << cidx | ||
|
|
||
| pid := procPin() | ||
| l := len(p.active[pid][cidx]) | ||
| if l > 0 { | ||
| data = p.active[pid][cidx][l-1][:size:capacity] | ||
| p.active[pid][cidx] = p.active[pid][cidx][:l-1] | ||
| procUnpin() | ||
| if debug { | ||
| log.Printf("PCACHE: P[%d] reuse active %d bytes, addr %d", pid, clen, uintptr(unsafe.Pointer(&data[:1][0]))) | ||
| } | ||
| return data | ||
| } | ||
|
|
||
| l = len(p.inactive[pid][cidx]) | ||
| if l > 0 { | ||
| data = p.inactive[pid][cidx][l-1][:size:capacity] | ||
| p.inactive[pid][cidx] = p.inactive[pid][cidx][:l-1] | ||
| procUnpin() | ||
| if debug { | ||
| log.Printf("PCACHE: P[%d] reuse inactive %d bytes, addr %d", pid, clen, uintptr(unsafe.Pointer(&data[:1][0]))) | ||
| } | ||
| return data | ||
| } | ||
|
|
||
| if clen <= len(p.activeBlocks[pid]) { | ||
| data = p.activeBlocks[pid][:size:capacity] | ||
| p.activeBlocks[pid] = p.activeBlocks[pid][clen:] | ||
| procUnpin() | ||
| if debug { | ||
| log.Printf("PCACHE: P[%d] malloc from activeBlock %d bytes, addr %d", pid, clen, uintptr(unsafe.Pointer(&data[:1][0]))) | ||
| } | ||
| return data | ||
| } | ||
|
|
||
| if clen > len(p.inactiveBlocks[pid]) { | ||
| if clen < defaultPCacheBlockSize { | ||
| p.inactiveBlocks[pid] = make([]byte, defaultPCacheBlockSize) | ||
| } else { | ||
| p.inactiveBlocks[pid] = make([]byte, clen) | ||
| } | ||
| } | ||
| data = p.inactiveBlocks[pid][:size:capacity] | ||
| p.inactiveBlocks[pid] = p.inactiveBlocks[pid][clen:] | ||
| procUnpin() | ||
| if debug { | ||
| log.Printf("PCACHE: P[%d] malloc from inactiveBlock %d bytes, addr %d", pid, clen, uintptr(unsafe.Pointer(&data[:1][0]))) | ||
| } | ||
| return data | ||
| } | ||
|
|
||
| func (p *pcache) Free(data []byte) { | ||
| capacity := cap(data) | ||
| if capacity == 0 { | ||
| return | ||
| } | ||
| cidx := calcCapIndex(capacity) | ||
| clen := 1 << cidx | ||
| dp := (*reflect.SliceHeader)(unsafe.Pointer(&data)) | ||
| addr := dp.Data | ||
| data = data[:0] | ||
| dp.Cap = clen | ||
|
|
||
| pid := procPin() | ||
| if addr >= p.arenaStart && addr <= p.arenaEnd { | ||
| p.active[pid][cidx] = append(p.active[pid][cidx], data) | ||
| procUnpin() | ||
| if debug { | ||
| log.Printf("PCACHE: P[%d] free active %d bytes, addr %d", pid, clen, addr) | ||
| } | ||
| return | ||
| } | ||
|
|
||
| p.inactive[pid][cidx] = append(p.inactive[pid][cidx], data) | ||
| procUnpin() | ||
| if debug { | ||
| log.Printf("PCACHE: P[%d] free inactive %d bytes, addr %d", pid, clen, addr) | ||
| } | ||
| } | ||
|
|
||
| func calcCapIndex(size int) int { | ||
| if size == 0 { | ||
| return 0 | ||
| } | ||
| if isPowerOfTwo(size) { | ||
| return bsr(size) | ||
| } | ||
| return bsr(size) + 1 | ||
| } | ||
|
|
||
| func bsr(x int) int { | ||
| return bits.Len(uint(x)) - 1 | ||
| } | ||
|
|
||
| func isPowerOfTwo(x int) bool { | ||
| return (x & (-x)) == x | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,138 @@ | ||
| //+build !race | ||
joway marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| package netpoll | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "runtime" | ||
| "sync" | ||
| "testing" | ||
|
|
||
| "github.com/bytedance/gopkg/lang/mcache" | ||
| ) | ||
|
|
||
| func TestPCacheSingleP(t *testing.T) { | ||
| procs := runtime.GOMAXPROCS(0) | ||
| runtime.GOMAXPROCS(1) | ||
| defer runtime.GOMAXPROCS(procs) | ||
| Equal(t, runtime.GOMAXPROCS(0), 1) | ||
|
|
||
| pc := newPCache() | ||
| buf := pc.Malloc(1024, 1025) | ||
| Equal(t, len(buf), 1024) | ||
| Equal(t, cap(buf), 1025) | ||
| pc.Free(buf) | ||
| Equal(t, len(pc.active[0][calcCapIndex(1025)]), 1) | ||
|
|
||
| buf = pc.Malloc(1024, 1024) | ||
| Equal(t, len(buf), 1024) | ||
| Equal(t, cap(buf), 1024) | ||
| pc.Free(buf) | ||
| Equal(t, len(pc.active[0][calcCapIndex(1024)]), 1) | ||
| Equal(t, len(pc.active[0][calcCapIndex(1025)]), 1) | ||
| } | ||
|
|
||
| func TestPCacheMultiP(t *testing.T) { | ||
| pc := newLimitedPCache(1024) // 1KB | ||
| size := 50 | ||
| testdata := make([]byte, size) | ||
| for i := 0; i < len(testdata); i++ { | ||
| testdata[i] = 'a' + byte(i%26) | ||
| } | ||
| procs := runtime.GOMAXPROCS(0) | ||
| var wg sync.WaitGroup | ||
| for i := 0; i < procs; i++ { | ||
| wg.Add(1) | ||
| go func() { | ||
| defer wg.Done() | ||
| for j := 0; j < 1000; j++ { | ||
| buf := pc.Malloc(size, size) | ||
| copy(buf, testdata) | ||
| Equal(t, len(buf), size) | ||
| Equal(t, cap(buf), size) | ||
| Equal(t, string(buf), string(testdata)) | ||
| runtime.Gosched() | ||
| pc.Free(buf) | ||
| } | ||
| }() | ||
| } | ||
| wg.Wait() | ||
| } | ||
|
|
||
| func TestPCacheGC(t *testing.T) { | ||
| procs := runtime.GOMAXPROCS(0) | ||
| runtime.GOMAXPROCS(1) | ||
| defer runtime.GOMAXPROCS(procs) | ||
| Equal(t, runtime.GOMAXPROCS(0), 1) | ||
|
|
||
| pc := newLimitedPCache(1024) | ||
| buf1 := pc.Malloc(1024, 1024) | ||
| buf2 := pc.Malloc(1024, 1024) | ||
| Equal(t, len(buf1), 1024) | ||
| Equal(t, cap(buf1), 1024) | ||
| Equal(t, len(buf2), 1024) | ||
| Equal(t, cap(buf2), 1024) | ||
| pc.Free(buf1) | ||
| pc.Free(buf2) | ||
| Equal(t, len(pc.active[0][calcCapIndex(1024)]), 1) | ||
| Equal(t, len(pc.inactive[0][calcCapIndex(1024)]), 1) | ||
|
|
||
| for i := 0; i < defaultPCacheCleanCycles; i++ { | ||
| runtime.GC() | ||
| } | ||
| Equal(t, len(pc.active[0][calcCapIndex(1024)]), 1) | ||
| Equal(t, len(pc.inactive[0][calcCapIndex(1024)]), 0) | ||
| buf1 = pc.Malloc(1024, 1024) | ||
| buf2 = pc.Malloc(1024, 1024) | ||
| pc.Free(buf1) | ||
| pc.Free(buf2) | ||
| Equal(t, len(pc.active[0][calcCapIndex(1024)]), 1) | ||
| Equal(t, len(pc.inactive[0][calcCapIndex(1024)]), 1) | ||
| for i := 0; i < defaultPCacheCleanCycles; i++ { | ||
| runtime.GC() | ||
| } | ||
| Equal(t, len(pc.active[0][calcCapIndex(1024)]), 1) | ||
| Equal(t, len(pc.inactive[0][calcCapIndex(1024)]), 0) | ||
| } | ||
|
|
||
| var benchSizes = []int{ | ||
| 1024, | ||
| 1024 * 8, 1024 * 64, // small size | ||
| 1024 * 1024, 1024 * 1024 * 8, // large size | ||
| } // unit: Bytes | ||
|
|
||
| func BenchmarkPCache(b *testing.B) { | ||
| for _, size := range benchSizes { | ||
| pc := newLimitedPCache(1024 * 1024 * 1) // 1MB | ||
| b.Run(fmt.Sprintf("Malloc-%d", size), func(b *testing.B) { | ||
| b.RunParallel(func(pb *testing.PB) { | ||
| for pb.Next() { | ||
| buf := pc.Malloc(size) | ||
| pc.Free(buf) | ||
| } | ||
| }) | ||
| }) | ||
| d := make([]int, len(pc.active)) | ||
| for pid := 0; pid < len(pc.active); pid++ { | ||
| for cidx := 0; cidx < len(pc.active[pid]); cidx++ { | ||
| for i := 0; i < len(pc.active[pid][cidx]); i++ { | ||
| d[pid] += cap(pc.active[pid][cidx][i]) | ||
| } | ||
| } | ||
| } | ||
| b.Logf("pcache-%d active distribution: %v", size, d) | ||
| } | ||
| } | ||
|
|
||
| func BenchmarkMCache(b *testing.B) { | ||
| for _, size := range benchSizes { | ||
| b.Run(fmt.Sprintf("Malloc-%d", size), func(b *testing.B) { | ||
| b.RunParallel(func(pb *testing.PB) { | ||
| for pb.Next() { | ||
| buf := mcache.Malloc(size) | ||
| mcache.Free(buf) | ||
| } | ||
| }) | ||
| }) | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.