Skip to content

fix:(conv/j2t) not recurse in tb_write_default_or_empty to avoid dead-looping on cycle-referred struct#89

Merged
AsterDY merged 4 commits intomainfrom
feat/http_trace
Mar 2, 2025
Merged

fix:(conv/j2t) not recurse in tb_write_default_or_empty to avoid dead-looping on cycle-referred struct#89
AsterDY merged 4 commits intomainfrom
feat/http_trace

Conversation

@AsterDY
Copy link
Collaborator

@AsterDY AsterDY commented Feb 21, 2025

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:

  • not recurse in tb_write_default_or_empty to avoid dead-looping on cycle-referred struct
  • didn't unescape json key string in fallback mode

zh(optional):

  • tb_write_default_or_empty写结构体空值时不递归,避免循环引用引起死循环
  • fallback模式下没有对json key做字符串转义

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@AsterDY AsterDY merged commit fefc46e into main Mar 2, 2025
39 of 41 checks passed
khan-yin pushed a commit to khan-yin/dynamicgo that referenced this pull request Apr 26, 2025
…ad-looping on cycle-referred struct (cloudwego#89)

* fix: judge escape string wrong

* fix: not recurse in `tb_write_default_or_empty` to avoid dead-loop

* change test

* update README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants