Repository navigation
fix: Rename chart icon to bar-chart - #5257
Merged
Merged
Conversation
jperals
marked this pull request as ready for review
November 5, 2026 08:08
jperals
requested review from
at-susie and
cansuaa
and
a balanced review from Copilot
and removed request for
a team
November 5, 2026 08:08
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the icon rename.
No open issues 🎉
What changed in this PR
Renames the unreleased chart icon to bar-chart, establishing a more specific naming pattern for future chart icons without affecting released consumers.
Changes:
- Provides the SVG asset under the
bar-chartname. - Replaces
chartwithbar-chartin the built-in icon type. - Updates documentation snapshots to reflect the new name.
| File | Description |
|---|---|
src/icon/icons/bar-chart.svg |
Provides the bar-chart SVG asset. |
src/icon-provider/interfaces.ts |
Updates the built-in icon name union. |
src/__tests__/snapshot-tests/__snapshots__/documenter.test.ts.snap |
Aligns icon names in documentation snapshots. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5257 +/- ##
=======================================
Coverage 97.82% 97.82%
=======================================
Files 1006 1006
Lines 32566 32566
Branches 12095 12095
=======================================
Hits 31857 31857
Misses 703 703
Partials 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
/override-visual-regression Diffs are caused by the icons getting reordered |
jperals
enabled auto-merge
November 5, 2026 11:00
at-susie
approved these changes
Nov 5, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a more future-proof name as it allows more consistency for icons for other types of chart, such as
line-chart, are released later.The
charticon has not been released yet, so this change cannot break any consumers.How has this been tested?
Updated snapshots
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.