Skip to content

fix: Rename chart icon to bar-chart - #5257

Merged
jperals merged 1 commit into
mainfrom
dev-v3-jotresse-rename-chart-icon
Nov 5, 2026
Merged

jperals merged 1 commit into
mainfrom
dev-v3-jotresse-rename-chart-icon

Conversation

@jperals

@jperals jperals commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Description

This is a more future-proof name as it allows more consistency for icons for other types of chart, such as line-chart, are released later.

The chart icon has not been released yet, so this change cannot break any consumers.

How has this been tested?

Updated snapshots

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jperals
jperals marked this pull request as ready for review November 5, 2026 08:08
@jperals
jperals requested a review from a team as a code owner November 5, 2026 08:08
@jperals
jperals requested review from at-susie and cansuaa and a balanced review from Copilot and removed request for a team November 5, 2026 08:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the icon rename.

No open issues 🎉

What changed in this PR

Renames the unreleased chart icon to bar-chart, establishing a more specific naming pattern for future chart icons without affecting released consumers.

Changes:

  • Provides the SVG asset under the bar-chart name.
  • Replaces chart with bar-chart in the built-in icon type.
  • Updates documentation snapshots to reflect the new name.
File Description
src/​icon/​icons/​bar-chart.svg Provides the bar-chart SVG asset.
src/​icon-provider/​interfaces.ts Updates the built-in icon name union.
src/​__tests__/​snapshot-tests/​__snapshots__/​documenter.test.ts.snap Aligns icon names in documentation snapshots.

Review effort: Balanced

@codecov

codecov Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.82%. Comparing base (c7e4aef) to head (6b1f8bb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5257   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files        1006     1006           
  Lines       32566    32566           
  Branches    12095    12095           
=======================================
  Hits        31857    31857           
  Misses        703      703           
  Partials        6        6           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jperals

jperals commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

/override-visual-regression Diffs are caused by the icons getting reordered

@jperals
jperals added this pull request to the merge queue Nov 5, 2026
Merged via the queue into main with commit 3e2e96d Nov 5, 2026
105 of 111 checks passed
@jperals
jperals deleted the dev-v3-jotresse-rename-chart-icon branch November 5, 2026 12:15

This branch was successfully deployed

3 active deployments
dev-pages-react18 — 6b1f8bbb Deployed Nov 5, 2026 by jperals via deploy (React 18) / deploy #3183
dev-pages-react16 — 6b1f8bbb Deployed Nov 5, 2026 by jperals via deploy (React 16) / deploy #3183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants