Skip to content

fix: Token with dismisms button has awkward space - #5253

Merged
SpyZzey merged 1 commit into
mainfrom
fix/token-awkward-space
Nov 5, 2026
Merged

SpyZzey merged 1 commit into
mainfrom
fix/token-awkward-space

Conversation

@SpyZzey

@SpyZzey SpyZzey commented Nov 4, 2026

Copy link
Copy Markdown
Member

Description

The token (and all consuming components of token, e.g., multiselect or property input) has awkward space since #5189

This PR fixes it by making the dismiss button a flexbox.

Before
Screenshot 2026-11-04 at 11 47 23

After
Screenshot 2026-11-04 at 11 47 40

Related links, issue #, if available: D574288049

How has this been tested?

Manual tests

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Nov 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.82%. Comparing base (6a65c00) to head (95f8708).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5253   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files        1006     1006           
  Lines       32620    32620           
  Branches    12120    12121    +1     
=======================================
  Hits        31911    31911           
+ Misses        703      667   -36     
- Partials        6       42   +36     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SpyZzey
SpyZzey added this pull request to the merge queue Nov 5, 2026
Merged via the queue into main with commit d2e84d8 Nov 5, 2026
104 of 105 checks passed
@SpyZzey
SpyZzey deleted the fix/token-awkward-space branch November 5, 2026 13:43

This branch was successfully deployed

3 active deployments
dev-pages-react18 — 95f87087 Deployed Nov 4, 2026 by SpyZzey via deploy (React 18) / deploy #3168
dev-pages-react16 — 95f87087 Deployed Nov 4, 2026 by SpyZzey via deploy (React 16) / deploy #3168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants