Repository navigation
feat: Report async loading usage in dropdown component metadata - #5245
Open
gethinwebster wants to merge 1 commit into
Open
gethinwebster wants to merge 1 commit into
gethinwebster wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5245 +/- ##
=======================================
Coverage 97.82% 97.82%
=======================================
Files 1006 1006
Lines 32608 32608
Branches 12106 12107 +1
=======================================
Hits 31900 31900
+ Misses 702 666 -36
- Partials 6 42 +36 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jperals
approved these changes
Nov 4, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
hasAsyncLoadingflag to the usage metadata of Select, Multiselect, Autosuggest, PropertyFilter and ButtonDropdown. It istruewhen the consumer passesonLoadItems, so we can see how many instances use async-loaded options. The value is fixed at mount;statusTypeis not reported because it changes at runtime.Related links, issue #, if available: n/a
How has this been tested?
Added tests for components that already had suites testing analytics metadata.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.