Skip to content

feat: Add 4 new icons - #5240

Merged
jperals merged 2 commits into
mainfrom
dev-v3-jotresse-query-builder-icons
Nov 4, 2026
Merged

jperals merged 2 commits into
mainfrom
dev-v3-jotresse-query-builder-icons

Conversation

@jperals

@jperals jperals commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Description

Adds icons: chart, eye, sliders, view-vertical-start.

How has this been tested?

Existing visual regression tests

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The four-icon addition has no active review issues.

No open issues 🎉

What changed in this PR

Adds four built-in icons to Cloudscape’s icon library: chart, eye, sliders, and view-vertical-start.

Changes:

  • Adds SVG assets and exposes their names through the icon provider’s public type.
  • Adds right-to-left mirroring and hover animation for view-vertical-start.
  • Updates documentation snapshots and raises the widget-export bundle size limit from 1460 kB to 1470 kB.
File Description
src/​icon/​styles.scss Enables right-to-left mirroring for view-vertical-start.
src/​icon/​icons/​view-vertical-start.svg Adds the start-aligned vertical panel icon.
src/​icon/​icons/​sliders.svg Adds the sliders icon.
src/​icon/​icons/​eye.svg Adds the eye icon.
src/​icon/​icons/​chart.svg Adds the chart icon.
src/​icon/​hover-motion.scss Defines the new panel icon’s hover animation.
src/​icon-provider/​interfaces.ts Adds all four names to BuiltInIconName.
src/​__tests__/​snapshot-tests/​__snapshots__/​documenter.test.ts.snap Updates API documentation snapshots with the new icons.
package.json Increases the widget-export bundle size allowance.

Review effort: Balanced

@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.82%. Comparing base (c8ca653) to head (e6dc32f).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5240      +/-   ##
==========================================
+ Coverage   97.76%   97.82%   +0.06%     
==========================================
  Files        1003     1006       +3     
  Lines       32572    32583      +11     
  Branches    12110    12094      -16     
==========================================
+ Hits        31843    31875      +32     
+ Misses        684      666      -18     
+ Partials       45       42       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jperals
jperals marked this pull request as ready for review November 3, 2026 15:35
@jperals
jperals requested a review from a team as a code owner November 3, 2026 15:35
@jperals
jperals requested review from SpyZzey and at-susie and removed request for a team November 3, 2026 15:35
<svg x="1" y="1" width="14" height="14" viewBox="1 1 14 14" overflow="hidden">
<path class="filled no-stroke awsui-icon-panel" d="M8.5 4H4.5C4.22386 4 4 4.22386 4 4.5V11.5C4 11.7761 4.22386 12 4.5 12H8.5C8.77614 12 9 11.7761 9 11.5V4.5C9 4.22386 8.77614 4 8.5 4Z" />
</svg>
</svg>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a svg tag is nested in another svg tag

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! But I think this is fine. It was copied over from the existing view-vertical icon, was introduced here along with the icon animations and I think the purpose of the internal SVG tag is to to clip its internal element when it is animated away on hover. That is why it has overflow="hidden". A group (g tag) cannot clip in the same way.

I can't find evidence of nested SVGs being invalid, and MDN has an example of it here.

@jperals

jperals commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

/override-visual-regression Expected changes from new icons

@jperals
jperals added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit 8716cbf Nov 4, 2026
88 of 91 checks passed
@jperals
jperals deleted the dev-v3-jotresse-query-builder-icons branch November 4, 2026 08:01

This branch was successfully deployed

3 active deployments
dev-pages-react16 — e6dc32f2 Deployed Nov 3, 2026 by jperals via deploy (React 16) / deploy #3142
dev-pages-react18 — e6dc32f2 Deployed Nov 3, 2026 by jperals via deploy (React 18) / deploy #3142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants