Repository navigation
chore: Add underline styling for the inline-link button for one-theme - #5237
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5237 +/- ##
=======================================
Coverage 97.82% 97.82%
=======================================
Files 1006 1006
Lines 32621 32621
Branches 12116 12117 +1
=======================================
Hits 31913 31913
+ Misses 702 666 -36
- Partials 6 42 +36 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
at-susie
marked this pull request as ready for review
November 3, 2026 14:54
at-susie
requested review from
cansuaa and
mxschll
and removed request for
a team and
cansuaa
November 3, 2026 14:54
mxschll
reviewed
Nov 3, 2026
| &.variant-inline-link { | ||
| @include theming.one-theme-only { | ||
| text-decoration-line: underline; | ||
| text-underline-offset: 3.5px; |
Member
There was a problem hiding this comment.
Do we have a linkTextDecoration token or something similar which we can use instead of the one-theme-only guard?
Member
Author
There was a problem hiding this comment.
No, but why not. So I introduced it
at-susie
force-pushed
the
dev-v3-onetheme-inline-link-button
branch
from
November 3, 2026 20:34
fb48a65 to
fdada55
Compare
at-susie
force-pushed
the
dev-v3-onetheme-inline-link-button
branch
from
November 4, 2026 07:52
548e7fc to
13d498d
Compare
mxschll
approved these changes
Nov 4, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Nov 4, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an underline style to the
inline-linkvariant of the button component to visually distinguish it as an inline interactive element, since in one-theme we changed the color to be neutral color from an accent color.Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.