Repository navigation
fix: Add role "switch" to toggle component - #5234
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5234 +/- ##
=======================================
Coverage 97.82% 97.82%
=======================================
Files 1006 1006
Lines 32583 32583
Branches 12094 12094
=======================================
Hits 31875 31875
Misses 666 666
Partials 42 42 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The switch-role fix lacks a targeted regression assertion, so the existing tests would not catch removal of the role.
1 open issue
What changed in this PR
Updates the Toggle component’s accessibility semantics so screen readers identify it as a switch rather than a checkbox.
Changes:
- Adds
role="switch"to the native input while retainingtype="checkbox"and existing behavior.
| File | Description |
|---|---|
src/toggle/internal.tsx |
Adds the switch role to the Toggle input. |
Review effort: Balanced
gethinwebster
approved these changes
Nov 3, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 3, 2026
ernst-dev
pushed a commit
to TrevorBurnham/cloudscape-components
that referenced
this pull request
Nov 6, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Add role "switch" to toggle component. Currently NVDA and JAWS announce toggles as checkboxes, semantically and from announcement perspective it makes more sense for toggle to be announced as switch. Both roles are very similar, it shouldn't create a difference for us except the way the toggle component is announced.
Related links, issue #, if available: AWSUI-62424
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.