Repository navigation
fix: Ignore select options while disabled - #5232
Open
Xapollon430 wants to merge 1 commit into
Open
Xapollon430 wants to merge 1 commit into
Xapollon430 wants to merge 1 commit into
Conversation
Reject user selection after the parent becomes disabled while its menu is open. Signed-off-by: Vehbi Karaagac <Xapollon430@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5231.
Problem
I was playing around with the
Selectcomponent and noticed a bug where:disabledtotruewhile the menu is open.onChangestill fires.Here is a reproduction video of the issue:
Recorded against @cloudscape-design/components 3.0.1408. Runnable reproduction includes the required styles and setup.
cloudscape-disabled-repro.mp4
A React re-render can send
disabled=trueafter the menu is already open. In an application, that could happen when an asynchronous request completes or a timer fires while someone is choosing an option. The case here is the parent control becoming disabled; the options haven't been individually marked disabled.My first thought was to close the popup, since that is what I observed with a native HTML
selectin Chromium. The HTML option-picking algorithm also stops without selecting an option when its select is disabled.Closing on disable is a reasonable choice too. I'm happy to adjust the PR to follow the library's preferred behavior. The behavior I'm trying to guarantee is simply that a control stops accepting user selections once it becomes disabled.
This change checks the current disabled state before emitting a selection change from the open dropdown. It keeps the existing popup behavior.
I started investigating this interaction while using Hegel to vary component props and Bombadil to exercise UI actions in Anta. I then reproduced this library's behavior separately; the video above is from that reproduction.
Validation
248 Select tests pass across 16 suites; the full production build, full ESLint/stylelint, and scoped formatting pass. The regression covers both expandToViewport modes using the official test utilities. The new regression fails without the fix.
AI-assisted implementation and testing.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.