Repository navigation
chore: Adds internal style api v2 to textarea - #5191
Merged
Merged
Conversation
vvaliyev
force-pushed
the
style-v2-textarea
branch
from
October 26, 2026 13:03
c216be5 to
80f95d1
Compare
vvaliyev
force-pushed
the
style-v2-textarea
branch
from
October 26, 2026 13:09
80f95d1 to
c646ebf
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The scoped implementation follows existing Style API patterns, with no unresolved correctness or compatibility findings.
No open issues 🎉
What changed in this PR
Adds internal Style API v2 support to Textarea through a single textarea slot on the native field element.
Changes:
- Adds slot class support, placeholder tokens, and generated styling documentation.
- Corrects three existing Style API v1 hover and focus fallbacks.
- Adds slot behavior tests, a documentation snapshot, and a styled demo page.
| File | Description |
|---|---|
src/textarea/styles.scss |
Registers styling tokens and documentation; corrects v1 fallbacks. |
src/textarea/index.tsx |
Applies the internal slot class to the native textarea. |
src/textarea/__tests__/style-api.test.tsx |
Tests slot placement, component states, and prop filtering. |
src/__tests__/snapshot-tests/__snapshots__/style-docs.test.ts.snap |
Adds Textarea styling documentation snapshots. |
pages/textarea/style-api-v2.scss |
Defines demo styles using the generated mixin. |
pages/textarea/style-api-v2.page.tsx |
Demonstrates styling across Textarea states. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5191 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 996 996
Lines 32222 32224 +2
Branches 11909 11909
=======================================
+ Hits 31493 31495 +2
- Misses 684 723 +39
+ Partials 45 6 -39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pan-kot
approved these changes
Oct 26, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the internal Style API v2 to Textarea with one slot,
textarea, on the native<textarea>element, which is also the field box.Tracker section: P3d34KdbCd6o.
How has this been tested?
npm run build, unit tests forsrc/textareaand the style-docs snapshot, prettier, stylelint, eslint.src/textarea/__tests__/style-api.test.tsx: the slot class lands on the native textarea in every state, unknown keys are ignored, the prop does not reach the DOM, v1 inline styles still apply.pages/textarea/style-api-v2styled only through the generatedtextarea.textarea()mixin, one permutation per row and per documented state; verified in the browser. No VR baseline yet (not registered in the VR suite, same as the other style-api-v2 pages).