[vvaliyev]

Description

Input now always renders a wrapper (div.input-field) around the native <input>. The wrapper paints the field (border, background, shadow, all states); the native input is borderless and only owns text styles.

Before, the native input painted the field on its own, and a separate container took over when prefix/suffix was set, so every state block existed twice in styles.scss. Now there is one set of surface rules on the field and one set of text rules on the input. CSS is ~4 KB smaller.

Public API and test-utils are unchanged. Two things to know:

• The native input's bounding box is 1px smaller on each side (it no longer carries the border). Two integ tests that measured it now measure the field, and Autosuggest measures its dropdown width on the Input root.
• The 1px border itself is not a click target, same as prefix/suffix inputs already behaved.

Rendering matches main except four fixes that fall out of the change:

• Focused read-only Input shows its focus ring (the read-only rule was clobbering it).
• Focused type=email/url with an invalid value shows its focus ring (.input:invalid { box-shadow: none }, meant for Firefox's glow, removed it too).
• Focused Input with prefix/suffix no longer paints square corners over the rounded border.
• v1 style prop with prefix/suffix behaves like a plain Input.

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

• Changes include appropriate documentation updates.
• Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
• Changes do not include unsupported browser features, see CONTRIBUTING.md.
• Changes were manually tested for accessibility, see accessibility guidelines.

Security

• If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

• Changes are covered with new/existing unit tests?
• Changes are covered with new/existing integration tests?

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[Copilot]

🟡 Changes recommended

The new field styles override grouped-control corner rules, breaking joined Input and Autosuggest borders.

1 open finding

• Input field rule overrides grouped-control corner radii · New

What changed in this PR

Refactors Input so its field wrapper consistently owns borders, state styling, and sizing.

Changes:

• Always renders the Input field wrapper.
• Updates Autosuggest sizing and outside-click handling.
• Expands tests for field styling and interaction states.

File	Description
src/​input/​internal.tsx	Always renders the field wrapper.
src/​input/​styles.scss	Moves visual states onto the wrapper.
src/​internal/​components/​autosuggest-input/​index.tsx	Observes and tracks the input container.
src/​input/​__tests__/​adornments.test.tsx	Tests wrapper behavior and styling.
src/​select/​__tests__/​filter.test.tsx	Updates the border-radius assertion.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.72%. Comparing base (8bbfddc) to head (880690c).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5126      +/-   ##
==========================================
- Coverage   97.72%   97.72%   -0.01%     
==========================================
  Files         995      995              
  Lines       32138    32129       -9     
  Branches    11861    11851      -10     
==========================================
- Hits        31408    31399       -9     
  Misses        684      684              
  Partials       46       46              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

🟡 Changes recommended

Field-border clicks can no longer reopen a focused autosuggest after Escape.

1 open finding

• Forward border clicks to reopen autosuggest after Escape · New

1 resolved since last review

• Input field rule overrides grouped-control corner radii

🧠 Review effort: Balanced

[Copilot]

🟢 Approval recommended

The implementation is coherent and covered by existing visual tests; only a non-blocking comment cleanup remains.

2 open findings

• Forward border clicks to reopen autosuggest after Escape
• Remove redundant comment duplicating styles.scss explanation · New

🧠 Review effort: Balanced

[Copilot]

🔵 Needs a closer look

The cross-browser visual and interaction impact of the CSS and DOM restructuring requires final human validation.

0 open findings

2 resolved since last review

• Forward border clicks to reopen autosuggest after Escape
• Remove redundant comment duplicating styles.scss explanation

🧠 Review effort: Balanced

[vvaliyev]

/override-visual-regression Expected: the four Input fixes listed in the description (focus states readonly/native-invalid/suffix/prefix entries, style-permutations #21);