Skip to content

feat(heureka): adds issue list to service image version details panel#869

Merged
hodanoori merged 11 commits intomainfrom
hoda-heureka-issuues-table
Apr 3, 2025
Merged

feat(heureka): adds issue list to service image version details panel#869
hodanoori merged 11 commits intomainfrom
hoda-heureka-issuues-table

Conversation

@hodanoori
Copy link
Contributor

@hodanoori hodanoori commented Apr 2, 2025

Summary

This pr adds issue list table to the image version details panel. To make it aligned with the supernova and doop ui look, I added issueIcon and issueTimestamp components to format the date. the list of issues for a specific image version is fetched once an image version is selected.

Changes Made

  • New components created for the issuesList and listItem.
  • IssueIcon and IssueTimestamp components are added to have the consistent UI same as doop and supernova
  • Issues list is added to the image version details panel.
  • NOTE: Pagination is not added to issues list in this PR as the ordering per severity is in progress on API side for issues entity which updates the pagination. So pagination will be added for this table in the next PR once BE change is there.

Related Issues

Screenshots (if applicable)

Uploading image.png…

Testing Instructions

  1. npm i
  2. npm run TASK

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

@hodanoori hodanoori requested a review from a team as a code owner April 2, 2025 13:21
@changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2025

🦋 Changeset detected

Latest commit: 8dc0481

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cloudoperators/juno-app-heureka Minor
@cloudoperators/juno-app-greenhouse Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ArtieReus ArtieReus added the heureka Heureka related issues label Apr 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-04-03 14:39 UTC

@ArtieReus
Copy link
Collaborator

UX review: Cells should be aligned to the top, see supernova as an example
Screenshot 2025-04-02 at 21 30 01

Copy link
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

edda
edda previously approved these changes Apr 3, 2025
@hodanoori
Copy link
Contributor Author

UX review: Cells should be aligned to the top, see supernova as an example Screenshot 2025-04-02 at 21 30 01

FIXED

@hodanoori hodanoori force-pushed the hoda-heureka-issuues-table branch from 6a97ca3 to 4a8f785 Compare April 3, 2025 09:28
Copy link
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@edda edda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with this!

@hodanoori hodanoori merged commit 527064c into main Apr 3, 2025
15 checks passed
@hodanoori hodanoori deleted the hoda-heureka-issuues-table branch April 3, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

heureka Heureka related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments