Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(juno): fix typescript errors (k8s client) #843

Merged
merged 5 commits into from
Mar 28, 2025

Conversation

mark-karnaukh-extern-sap
Copy link
Contributor

@mark-karnaukh-extern-sap mark-karnaukh-extern-sap commented Mar 24, 2025

Summary

Changes Made

  • Fix typescript errors (k8s client)

Related Issues

Screenshots (if applicable)

Testing Instructions

  1. npm i
  2. npm run TASK

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

Copy link

changeset-bot bot commented Mar 24, 2025

🦋 Changeset detected

Latest commit: ff572fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-k8s-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mark-karnaukh-extern-sap
Copy link
Contributor Author

mark-karnaukh-extern-sap commented Mar 24, 2025

@andypf @barsukov it should be merged after #833

@mark-karnaukh-extern-sap mark-karnaukh-extern-sap changed the title Task 812 fix typescript errors k8s client refactor(juno): fix typescript errors (k8s client) Mar 24, 2025
@mark-karnaukh-extern-sap mark-karnaukh-extern-sap force-pushed the task-812-fix-typescript-errors-k8s-client branch from 0719ab1 to 49e4da1 Compare March 26, 2025 14:07
andypf
andypf previously approved these changes Mar 28, 2025
@mark-karnaukh-extern-sap mark-karnaukh-extern-sap force-pushed the task-812-fix-typescript-errors-k8s-client branch from 49e4da1 to ff572fb Compare March 28, 2025 10:05
@mark-karnaukh-extern-sap mark-karnaukh-extern-sap marked this pull request as ready for review March 28, 2025 10:05
@mark-karnaukh-extern-sap mark-karnaukh-extern-sap requested a review from a team as a code owner March 28, 2025 10:05
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barsukov barsukov merged commit f1463a6 into main Mar 28, 2025
13 checks passed
@barsukov barsukov deleted the task-812-fix-typescript-errors-k8s-client branch March 28, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants