Update kube router iptables 1.8.11 #1790
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like they fixed goconst upstream and it no longer checks this
This commit should never be merged to master, this is just here as a temporary change to allow people to test with a version of kube-router that has a modern iptables userspace. Hopefully Alpine will carry this package officially in an upcoming release.
This was referenced Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mrueg
This is a PR that attempts to update kube-router versions across the board including many of the utilities and tools that kube-router relies on like
golangci-lint,gomoq,goreleaser, etc.This PR is marked as draft as it currently carries a custom built version of iptables-1.8.11 as Alpine is still currently shipping iptables-1.8.10 in their latest releases. However, that version of iptables breaks kube-router's usage of iptables and so is not ship-able (see: #1789).
For now, this PR is just for staging and to get an official version of kube-router built that has a newer iptables user-space so that curious users can test if i they want to know if it would fix issues with user-space compatibilities.
Once Alpine creates a release that includes iptables-1.8.11, the commit
feat(iptables): add custom iptables-1.8.11 APKscan be removed, Alpine can be updated in:feat: update to go 1.22.3->1.23.4 and alpine 3.18->3.21with an interactive rebase and this can be merged.