fix: support base-image extension dependencies - #338
Open
ardentperf wants to merge 1 commit into
Open
Conversation
Keep local repository dependency resolution unchanged while allowing required PostgreSQL extensions supplied by the base image to be installed during testing without treating them as extension images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current code doesn't work if an extension dependency is in the base image. I ran into this while working on
pg-stat-kcacheandpgsentinelwhich both depend onpg_stat_statements.We need to support both models - some dependencies are not in the base image (eg.
pgroutingormobilitydb)Proposed behavior
Base-image dependencies use an explicit prefix in the existing
required_extensionsfield:For such a dependency:
Unprefixed dependencies retain the current local-repository behavior, and a missing unprefixed dependency remains an error.
Validation
DAGGER_SESSION_PORT=1 DAGGER_SESSION_TOKEN=test go test ./....github/workflows/test.ymlunit-test job viaact--checkforpg-crash,pg-ivm,pgaudit,pgrouting,pgvector,postgis,timescaledb-oss, andwal2json