Support improved Node Cellar simple blueprint #416
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the tests will obviously fail until the cloudify-nodecellar-example pull request is merged into its master. |
tliron
force-pushed
the
CFY-5360
branch
2 times, most recently
from
8fac80e to
cbf7802
Compare
| @@ -34,7 +34,8 @@ def get_public_ip(self, nodes_state): | |||
|
|
|||
| def get_inputs(self): | |||
| return dict(self.access_credentials, | |||
| **{'host_ip': self.private_ip_address}) | |||
| **{'nodejs_host_ip': self.private_ip_address, | |||
| 'mongod_host_ip': self.private_ip_address}) | |||
|
|
|||
| @property | |||
| def expected_nodes_count(self): | |||
There was a problem hiding this comment.
entrypoint_node_name should be nodejs_host
|
Closed: As this PR is more than six months old without having been merged. Please reopen (and rebase if necessary) if it is still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In conjunction with this pull request:
cloudify-cosmo/cloudify-nodecellar-example#91