Pre-upgrade helm hook to label resources with space-guid #3734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hook labels Korifi existing resources (`cfapps`, `cfbuilds`, `cfpackages`, `cfprocesses`, `cfroutes`, `cfservicebindings`, `cfserviceinstances`, `cftasks`) with the `korifi.cloudfoundry.org/space-guid` label. This label is needed to adopt improvements in resource listing (see #3636) The hook runs on pre-upgrade only, as it only make sense in an upgrade scenario. fixes #3672 Co-authored-by: Yusmen Zabanov <[email protected]> Co-authored-by: Danail Branekov <[email protected]>
danail-branekov
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3672
What is this change about?
This hook labels Korifi existing resources (
cfapps,cfbuilds,cfpackages,cfprocesses,cfroutes,cfservicebindings,cfserviceinstances,cftasks) with thekorifi.cloudfoundry.org/space-guidlabel. This label is needed toadopt improvements in resource listing (see #3636)
The hook runs on pre-upgrade only, as it only make sense in an upgrade
scenario.