Add ops file for disabling dynamic asg syncing on isolation segments #1239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is already a similar ops file for the regular "diego-cell" instances: I'm not yet sure how your new ops file relates to that one. Should the |
|
hi @ebroberson, As Jochen mention above there is already a similar ops file to disable the Dynamic ASG. Regards, |
|
Unfortunately that ops file only handles regular diego cells, not ones that are in an isolation segment. However, since the intended result is for Dynamic ASGs to be disabled for the entire deployment, I could modify the existing ops file to take isolation segments into account. Thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this change about?
We need the ability to disable Dynamic ASG syncing on an isolation segment for pipeline testing (particularly diego-release)
What customer problem is being addressed? Use customer persona to define the problem e.g. Alana is unable to...
Alana wants to easily disable the Dynamic ASG syncer on isolation segments.
Has a cf-deployment including this change passed cf-acceptance-tests?
Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.
How should this change be described in cf-deployment release notes?
Operators can now easily disable Dynamic ASG syncing for isolation segments.
Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?
Does this PR make a change to an experimental or GA'd feature/component?
Please provide Acceptance Criteria for this change?
Using
bosh interpolatewithdisable-isoseg-dynamic-asgs.ymlshould show thatisolated-diego-cell.vxlan-policy-agent.enable_asg_syncingisfalseWhat is the level of urgency for publishing this change?
@cloudfoundry/wg-app-runtime-platform