Add WarehouseInfo message and update data_source.proto for improved structure #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oved structure Signed-off-by: ImMin5 <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new WarehouseInfo message and updates the data_source.proto file to improve the structure of data messages in cost analysis.
- Added WarehouseInfo message with a WarehouseType enum.
- Updated RegisterDataSourceRequest and DataSourceInfo messages to include WarehouseInfo and adjusted field numbering.
| // +optional | ||
| PluginInfo plugin_info = 7; | ||
| Schedule schedule = 8; | ||
| // +optoinal |
There was a problem hiding this comment.
There is a typo in the comment: 'optoinal'. Please correct it to 'optional'.
Suggested change
| // +optoinal | |
| // +optional |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category
Description
Known issue