Skip to content

Conversation

@ImMin5
Copy link
Member

@ImMin5 ImMin5 commented May 28, 2025

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

Known issue

@ImMin5 ImMin5 requested a review from Copilot May 28, 2025 06:14
@ImMin5 ImMin5 self-assigned this May 28, 2025
@ImMin5 ImMin5 merged commit 93e12ee into cloudforet-io:master May 28, 2025
3 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the data source enums by adding a new value (WAREHOUSE) to support additional functionality.

  • Adds WAREHOUSE to the enum in RegisterDataSourceRequest
  • Adds WAREHOUSE to the enum in DataSourceInfo
Comments suppressed due to low confidence (2)

proto/spaceone/api/cost_analysis/v1/data_source.proto:184

  • Ensure that the introduction of the new enum value 'WAREHOUSE' is documented in the proto file and in associated client code, to maintain clear API expectations.
WAREHOUSE = 3;

proto/spaceone/api/cost_analysis/v1/data_source.proto:402

  • Ensure consistent usage and documentation for the new WAREHOUSE value across both enum definitions to avoid potential confusion in client-side implementation.
WAREHOUSE = 3;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant