Skip to content

Rename workspace_name to name in cost_report.proto for consistency #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ImMin5 merged 1 commit into from
May 23, 2025
Merged

Rename workspace_name to name in cost_report.proto for consistency #584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions proto/spaceone/api/cost_analysis/v1/cost_report.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ message CostReportQuery {
// +optional
string issue_date = 5;
// +optional
string workspace_name = 6;
string name = 6;
Copy link

Copilot AI May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming this field is a breaking change for existing clients. Consider marking the old workspace_name tag as deprecated = true and providing migration guidance or reserving the old field number.

Suggested change
string name = 6;
// Deprecated: Use an alternative field if applicable.
string name = 6 [deprecated = true];

Copilot uses AI. Check for mistakes.

}

Expand All @@ -103,7 +103,7 @@ message CostReportInfo {
string report_year = 8;
// YYYY-mm 2023-12
string report_month = 9;
string workspace_name = 10;
string name = 10;
string bank_name = 11;
bool is_adjusted = 12;
string cost_report_config_id = 21;
Expand Down
Loading