Skip to content

Rename PERCENTAGE to PERCENT in AdjustmentUnit enum and update related comments #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ImMin5 merged 1 commit into from
May 22, 2025
Merged

Rename PERCENTAGE to PERCENT in AdjustmentUnit enum and update related comments #583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion proto/spaceone/api/cost_analysis/v1/report_adjustment.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,17 @@ service ReportAdjustment {
enum AdjustmentUnit {
UNIT_NONE = 0;
FIXED = 1;
PERCENTAGE = 2;
PERCENT = 2;
}

//{
// "name" : "Service Fee Policy",
// "unit" : "FIXED",
// "value" : 10000.0,
// "description" : "Service Fee",
// "provider" : "AWS",
// "currency" : "USD"
//}
message CreateReportAdjustmentRequest {
string name = 1;
AdjustmentUnit unit = 2;
Expand All @@ -69,6 +77,8 @@ message CreateReportAdjustmentRequest {
string description = 4;
// +optional
string provider = 5;
// When created, the currency is set to the same as the cost report config.
// If currency changes, please use the sync_currency API.
// +optional
string currency = 6;
// +optional
Expand All @@ -78,6 +88,15 @@ message CreateReportAdjustmentRequest {
string report_adjustment_policy_id = 21;
}

//{
// "report_adjustment_id" : "report_adjustment_id",
// "name" : "Service Fee Policy",
// "unit" : "PERCENT",
// "value" : 10.0,
// "description" : "Service Fee",
// "provider" : "AWS",
// "adjustment_filter" : {}
//}
message UpdateReportAdjustmentRequest {
string report_adjustment_id = 1;
// +optional
Expand All @@ -94,6 +113,10 @@ message UpdateReportAdjustmentRequest {
google.protobuf.Struct adjustment_filter = 7;
}

//{
// "report_adjustment_id" : "report_adjustment_id",
// "order" : 2
//}
message ChangeOrderReportAdjustmentRequest {
string report_adjustment_id = 1;
int32 order = 2;
Expand Down
Loading