-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Key the Early Hints off of the asset key rather than request path #7564
Key the Early Hints off of the asset key rather than request path #7564
Conversation
🦋 Changeset detectedLatest commit: 17c97c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-wrangler-7564 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7564/npm-package-wrangler-7564 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-wrangler-7564 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-cloudflare-workers-bindings-extension-7564 -O ./cloudflare-workers-bindings-extension.0.0.0-v252f7469b.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v252f7469b.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-create-cloudflare-7564 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-cloudflare-kv-asset-handler-7564 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-miniflare-7564 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-cloudflare-pages-shared-7564 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-cloudflare-unenv-preset-7564 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-cloudflare-vitest-pool-workers-7564 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-cloudflare-workers-editor-shared-7564 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-cloudflare-workers-shared-7564 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-cloudflare-workflows-shared-7564 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
f5e99e6
to
a3bd7be
Compare
a3bd7be
to
17c97c2
Compare
Keys the Early Hints cache entries off of the asset key rather than the request path.
I could do something like we did for asset preservation v2 where we simultaneously checked the old and new formats to prevent a flood of new cache misses as we roll this out.