Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key the Early Hints off of the asset key rather than request path #7564

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

GregBrimble
Copy link
Member

Keys the Early Hints cache entries off of the asset key rather than the request path.

I could do something like we did for asset preservation v2 where we simultaneously checked the old and new formats to prevent a flood of new cache misses as we roll this out.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no coverage
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal change

@GregBrimble GregBrimble requested review from a team as code owners December 16, 2024 14:35
Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: 17c97c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/pages-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 16, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-wrangler-7564

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7564/npm-package-wrangler-7564

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-wrangler-7564 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-cloudflare-workers-bindings-extension-7564 -O ./cloudflare-workers-bindings-extension.0.0.0-v252f7469b.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v252f7469b.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-create-cloudflare-7564 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-cloudflare-kv-asset-handler-7564

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-miniflare-7564

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-cloudflare-pages-shared-7564

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-cloudflare-unenv-preset-7564

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-cloudflare-vitest-pool-workers-7564

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-cloudflare-workers-editor-shared-7564

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-cloudflare-workers-shared-7564

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12780994312/npm-package-cloudflare-workflows-shared-7564

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.2
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Base automatically changed from early-hints-store-empty-links to main January 7, 2025 18:15
@GregBrimble GregBrimble force-pushed the key-early-hints-off-of-asset-key-rather-than-path branch 5 times, most recently from f5e99e6 to a3bd7be Compare January 14, 2025 21:36
@GregBrimble GregBrimble force-pushed the key-early-hints-off-of-asset-key-rather-than-path branch from a3bd7be to 17c97c2 Compare January 15, 2025 03:31
@GregBrimble GregBrimble merged commit 147ab7d into main Jan 16, 2025
29 checks passed
@GregBrimble GregBrimble deleted the key-early-hints-off-of-asset-key-rather-than-path branch January 16, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants