fix: add body_json and content_type to queue messages - #1048
Open
SameerVers3 wants to merge 1 commit into
Open
Conversation
SameerVers3
force-pushed
the
fix/queue-body-json
branch
from
August 21, 2026 18:29
12c0b04 to
86c498e
Compare
Author
|
@guybedford Can you review this? |
jakubadamw
reviewed
Aug 30, 2026
| .content_type() | ||
| .unwrap() | ||
| .map(|s| match s.as_string().unwrap().as_str() { | ||
| "json" => QueueContentType::Json, |
Contributor
There was a problem hiding this comment.
Could use strum::EnumString here much like it’s done here. But I suppose this repetitive pattern is already spread across the module, so it’s a matter of taste.
Author
There was a problem hiding this comment.
yes you are correct, I missed it. updating it now
SameerVers3
force-pushed
the
fix/queue-body-json
branch
from
September 3, 2026 20:16
86c498e to
f3157d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1013
serde_wasm_bindgen::from_value is unreliable for types like serde_json::Value and tuples. This adds an escape hatch:
Also exposes content_type() on Message and RawMessage so consumers can inspect the producer's format.