feat: add bindings for inbound connect() TCP handler - #1041
Open
ThomasRubini wants to merge 7 commits into
Open
Conversation
ThomasRubini
changed the title
guybedford
reviewed
Aug 18, 2026
guybedford
left a comment
guybedford
left a comment
Collaborator
There was a problem hiding this comment.
It would be great to include this when ready. Please just make sure to include a full test once the SDK change has landed.
ThomasRubini
force-pushed
the
connect-bindings
branch
from
August 18, 2026 23:34
cd5bd64 to
4392022
Compare
Author
|
@guybedford AFAIK tests use miniflare and not wrangler, and miniflare is currently experimenting with a v5 alpha release, which means the only way to test connect() is to switch all tests to use an unstable (?) API |
ThomasRubini
marked this pull request as ready for review
August 20, 2026 18:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependent on cloudflare/workers-sdk#14995 because I'd love to add a wrangler config with the TCP handler in the example