Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some echos to the modified wd_test #3498

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add some echos to the modified wd_test #3498

wants to merge 1 commit into from
+3 −0

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Feb 7, 2025

Helps with debugging to have these in the log

@hoodmane hoodmane requested review from a team as code owners February 7, 2025 21:38
@hoodmane hoodmane marked this pull request as draft February 7, 2025 21:38
@hoodmane
Add some echos to the modified wd_test
db97472 
Helps with debugging to have these in the log
@hoodmane hoodmane force-pushed the hoodmane/python-snapshot-echo branch from 6a57fe0 to db97472 Compare February 7, 2025 21:41
@hoodmane hoodmane marked this pull request as ready for review February 7, 2025 21:41
fhanau
fhanau approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@fhanau fhanau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I assume that these are not logged when running bazel test the regular way, only when using --test_output=streamed or similar, while always being available in the test logs.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhanau fhanau fhanau approved these changes

@ObsidianMinor ObsidianMinor Awaiting requested review from ObsidianMinor ObsidianMinor is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoodmane @fhanau